[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 537299. hnrklssn added a comment. Update test cases after rebasing on ToT Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 Files:

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added a comment. (The patch description could use an update...) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 ___ cfe-commits mailing list

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 537286. hnrklssn added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: jplehr, sstefan1. Add unnamed global test case Added cases in generated-funcs.c with --check-globals all, testing that named and unnamed globals are matched

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. Herald added a subscriber: StephenFan. LGTM > Fixed. Does this test case exist somewhere? I couldn't find it upstream. That wasn't an existing test case. Though if you add a `--check-globals

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. @nikic Are you happy with the current patchset? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 ___ cfe-commits mailing list

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. @nikic Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. In D148216#4434171 , @nikic wrote: > There are some test failures. > > I believe there is one bug with the handling of unnamed globals. Previously > we produced this: > > ; NOTE: Assertions have been autogenerated by

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 532868. hnrklssn marked 4 inline comments as done. hnrklssn added a comment. Added back regex matchers for anonymous global values Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added a comment. There are some test failures. I believe there is one bug with the handling of unnamed globals. Previously we produced this: ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --check-globals --version 2 ; RUN: opt -S < %s | FileCheck

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn marked an inline comment as done. hnrklssn added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if action.dest == 'filters': nikic wrote: > nikic wrote: > > nikic wrote: >

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 532719. hnrklssn added a comment. Keep supporting --check-globals without explicit level as meaning '--check-globals all' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if action.dest == 'filters': nikic wrote: > nikic wrote: > > hnrklssn wrote: > > > nikic wrote: > > > > We should also

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if action.dest == 'filters': nikic wrote: > hnrklssn wrote: > > nikic wrote: > > > We should also not print the `all`

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if action.dest == 'filters': hnrklssn wrote: > nikic wrote: > > We should also not print the `all` argument for

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. In D148216#4431456 , @jdoerfert wrote: > could you put a little more information in the commit message please. "It > won't do X when we do Y", could mean a lot of things. We don't do Y anymore, > or we do X' now, with various

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 532649. hnrklssn added a comment. Rebase after reformatting with Black, update commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 Files:

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

jdoerfert added a comment. could you put a little more information in the commit message please. "It won't do X when we do Y", could mean a lot of things. We don't do Y anymore, or we do X' now, with various choices for X'. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added a comment. Could you please rebase the patch to current main? I wasn't able to apply it. The behavior you describe sounds reasonable to me. Comment at: llvm/utils/UpdateTestChecks/common.py:1286 + if value == default_value: +continue if

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. @nikic Ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn marked an inline comment as done. hnrklssn added a comment. @nikic Did you have a look at the new patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148216/new/ https://reviews.llvm.org/D148216

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn marked an inline comment as done. hnrklssn added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +//

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 526606. hnrklssn added a comment. Revert checker behaviour for global variables to check hard-coded identifiers Remove 'seen' mode Replace 'transitive' mode with 'smart', where attributes are no longer checked as metadata Introduce version bump to v3, and

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// hnrklssn wrote: > nikic wrote: > > hnrklssn

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// nikic wrote: > hnrklssn wrote: > > nikic

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// hnrklssn wrote: > nikic wrote: > > nikic

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// nikic wrote: > nikic wrote: > > hnrklssn

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 525174. hnrklssn added a comment. Herald added a subscriber: ormris. Overhauled how update_cc_tests.py checks globals It now: - no longer matches the literal names, like update_test_checks.py does unless --preserve-names (which doesn't seem to see much

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// nikic wrote: > hnrklssn wrote: > > hnrklssn

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// hnrklssn wrote: > hnrklssn wrote: > > nikic

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// hnrklssn wrote: > nikic wrote: > >

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// nikic wrote: > hnrklssn wrote: > >

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

nikic added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// hnrklssn wrote: > delcypher wrote: > >

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// delcypher wrote: > @hnrklssn I just

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

delcypher added inline comments. Comment at: clang/test/utils/update_cc_test_checks/Inputs/annotations.c.expected:12 +// CHECK-NEXT:[[TMP1:%.*]] = load i32, ptr [[X]], align 4 +// CHECK-NEXT:ret i32 [[TMP1]] +// @hnrklssn I just noticed we don't have a

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. In D148216#4266201 , @nikic wrote: > We should probably just use the `META` fallback for all metadata not already > explicitly handled. I think there's pretty little value in adding a special > name for each metadata kind. I

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn added a comment. In D148216#4266174 , @arichardson wrote: > Change looks good to me, but if clang can't emit these yet we should probably > wait until committing this? Do you have a link to a review that uses this > metadata? It can emit

[PATCH] D148216: Add support for annotations in UpdateTestChecks (NFC)

hnrklssn updated this revision to Diff 513589. hnrklssn added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add test case emitting !annotation from clang. Make annotation matching a generic metadata fallback. Repository: rG LLVM Github Monorepo CHANGES