[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

zhuhan0 added a comment. The patch failed a build bot which sets `LLVM_APPEND_VC_REV=OFF`. Fixed with https://reviews.llvm.org/rGee68f612ba682ddb911c5621e63df56039ec5824. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1f5e737fc135: [clang][cmake] Add options to pass in vcs repo and revision info (authored by zhuhan0). Repository: rG LLVM Github Monorepo

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

zhuhan0 updated this revision to Diff 513753. zhuhan0 added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148262/new/ https://reviews.llvm.org/D148262 Files: clang/lib/Basic/CMakeLists.txt

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

zhuhan0 added inline comments. Comment at: llvm/cmake/modules/GenerateVersionFromVCS.cmake:50 +endif() +append_info(${name} "${${name}_SOURCE_DIR}" "" "") endif() drodriguez wrote: > I would recommend changing the flow a little bit: > > - Remove

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

zhuhan0 added inline comments. Comment at: llvm/cmake/modules/GenerateVersionFromVCS.cmake:23-25 +if(path) + get_source_info("${path}" revision repository) +endif() drodriguez wrote: > Nit: Looks like tabs were added? These are not tabs but spaces.

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

drodriguez requested changes to this revision. drodriguez added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/CMakeLists.txt:16 set(llvm_source_dir ${LLVM_MAIN_SRC_DIR}) endif() if(clang_vc AND LLVM_APPEND_VC_REV)

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

zhuhan0 created this revision. Herald added subscribers: ekilmer, hoy, wenlei. Herald added a project: All. zhuhan0 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Clang may be built in an environment where Git is not