[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

dougpuob updated this revision to Diff 513648. dougpuob added a comment. - Removed unnecessary information from ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148314/new/ https://reviews.llvm.org/D148314 Files:

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. Change in tests is ok, change in release notes not needed (please remove). Change title into [clang-tidy][NFC] Improved ... NFC - Non Functional Change Repository: rG LLVM Github

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

dougpuob added a comment. In D148314#4267567 , @PiotrZSL wrote: > And you forget to attach changes in unit tests. My bad, I against to a wrong one. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:264-267 +- Improved readability

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

dougpuob updated this revision to Diff 513586. dougpuob added a comment. Herald added a subscriber: aheejin. Against trunk. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148314/new/ https://reviews.llvm.org/D148314 Files:

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

PiotrZSL added a comment. And you forget to attach changes in unit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148314/new/ https://reviews.llvm.org/D148314 ___ cfe-commits mailing list

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

PiotrZSL requested changes to this revision. PiotrZSL added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:264-267 +- Improved readability for hungarian notation in + :doc:`readability-identifier-naming + `

[PATCH] D148314: [clang-tidy] Improved hungarian notation regression test at post-commit review

dougpuob created this revision. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. dougpuob requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Improve the (`D144510`)[https://reviews.llvm.org/D144510]