This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG799b794d7699: [clang-format] C# short ternary operator
misinterpreted as a CSharpNullable (authored by MyDeveloperDay).
Changed prior to commit:
owenpan accepted this revision.
owenpan added inline comments.
Comment at: clang/unittests/Format/TokenAnnotatorTest.cpp:1730
+
+ auto Tokens = annotate("int? a;\n", Style);
+ EXPECT_EQ(Tokens.size(), 5u) << Tokens;
Nit: no trailing newlines here and below.
MyDeveloperDay updated this revision to Diff 514343.
MyDeveloperDay added a comment.
simplify negative if
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148473/new/
https://reviews.llvm.org/D148473
Files:
clang/lib/Format/TokenAnnotator.cpp
HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Format/TokenAnnotator.cpp:1338-1342
+if (!Contexts.back().IsExpression && Line.MustBeDeclaration &&
+
MyDeveloperDay added a comment.
@exv any thoughts on this one?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148473/new/
https://reviews.llvm.org/D148473
___
cfe-commits mailing list
MyDeveloperDay added a comment.
The exclusions are not complete for example `cond? foo() : "B";` would still
fail. but this moves us a little closer
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148473/new/
https://reviews.llvm.org/D148473
MyDeveloperDay created this revision.
MyDeveloperDay added a reviewer: owenpan.
MyDeveloperDay added a project: clang-format.
Herald added projects: All, clang.
Herald added reviewers: rymiel, HazardyKnusperkeks.
MyDeveloperDay requested review of this revision.
Refactor the CSharpNullable
