[PATCH] D148573: Allow -fsanitize=function on all targets

2023-05-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D148573#4361894 , @sbc100 wrote: > In D148573#4361509 , @MaskRay wrote: > >> In D148573#4361396 , @sbc100 wrote: >> >>> This change seems to

[PATCH] D148573: Allow -fsanitize=function on all targets

2023-05-22 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. In D148573#4361509 , @MaskRay wrote: > In D148573#4361396 , @sbc100 wrote: > >> This change seems to be causing problems on the emscripten auto-roller: >>

[PATCH] D148573: Allow -fsanitize=function on all targets

2023-05-22 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D148573#4361396 , @sbc100 wrote: > This change seems to be causing problems on the emscripten auto-roller: > https://ci.chromium.org/ui/p/emscripten-releases/builders/try/linux/b8780394114149321217/overview > > Failures show

[PATCH] D148573: Allow -fsanitize=function on all targets

2023-05-22 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. (I guess this also mean we are lacking some upstream testing for ubsan + wasm + mc?) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148573/new/ https://reviews.llvm.org/D148573

[PATCH] D148573: Allow -fsanitize=function on all targets

2023-05-22 Thread Sam Clegg via Phabricator via cfe-commits
sbc100 added a comment. This change seems to be causing problems on the emscripten auto-roller: https://ci.chromium.org/ui/p/emscripten-releases/builders/try/linux/b8780394114149321217/overview Failures show up in ubsan tests and look like this: error: symbol '_Z4testi' unsupported

[PATCH] D148573: Allow -fsanitize=function on all targets

2023-05-20 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay added a comment. In D148573#4358899 , @vitalybuka wrote: > These bots are broken after the patch > https://lab.llvm.org/buildbot/#/builders/77/builds/26834 > https://lab.llvm.org/buildbot/#/builders/18/builds/9073 The ppc64le has other

[PATCH] D148573: Allow -fsanitize=function on all targets

2023-05-20 Thread Vitaly Buka via Phabricator via cfe-commits
vitalybuka added a comment. These bots are broken after the patch https://lab.llvm.org/buildbot/#/builders/77/builds/26834 https://lab.llvm.org/buildbot/#/builders/18/builds/9073 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148573/new/

[PATCH] D148573: Allow -fsanitize=function on all targets

2023-05-19 Thread Fangrui Song via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67cbe1b85972: Allow -fsanitize=function on all targets (authored by MaskRay). Herald added subscribers: pcwang-thead, s.egerton, mstorsjo,

[PATCH] D148573: Allow -fsanitize=function on all targets

2023-04-19 Thread Fangrui Song via Phabricator via cfe-commits
MaskRay updated this revision to Diff 515161. MaskRay retitled this revision from "Port -fsanitize=function to AArch64" to "Allow -fsanitize=function on all targets". MaskRay edited the summary of this revision. MaskRay added a comment. Herald added subscribers: kadircet, ilya-biryukov. allow