This revision was automatically updated to reflect the committed changes.
Closed by commit rGac5c996d5aaa: [clang] Mark keywords that have their own
parsing rules (authored by rsandifo-arm).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148699/new/
rsandifo-arm updated this revision to Diff 526944.
rsandifo-arm added a comment.
Update base commit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148699/new/
https://reviews.llvm.org/D148699
Files:
clang/include/clang/Basic/Attr.td
Index:
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D148699/new/
https://reviews.llvm.org/D148699
erichkeane added a comment.
I see a lot of other attributes are being marked with this CustomKeyword
syntax, I find myself thinking tests should be written in terms of them, rather
than a 'new'/'incomplete' attribute
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
rsandifo-arm added a comment.
See https://reviews.llvm.org/D139028 for previous discussion on this topic.
https://reviews.llvm.org/D148700 contains the Attr.td support (and the main
rationale) while https://reviews.llvm.org/D148702 contains the main Parse &
Sema support.
Repository:
rG
rsandifo-arm created this revision.
rsandifo-arm added reviewers: erichkeane, aaron.ballman.
Herald added a project: All.
rsandifo-arm requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch retroactively classified all existing keyword
