[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG33ee5c466346: [clang] Add Parse and Sema support for RegularKeyword attributes (authored by rsandifo-arm). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm updated this revision to Diff 526936. rsandifo-arm marked an inline comment as done. rsandifo-arm added a comment. Rebase to account for a diagnostic that has moved. No other changes from the previous version. I'll wait for the build results before pushing. Thanks for the review!

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm marked an inline comment as done. rsandifo-arm added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:2902 S.Diag(AL.getRange().getBegin(), diag::err_attribute_wrong_decl_type) -<< AL << ExpectedTypeOrNamespace; +<< AL << 0 <<

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. 1 nit, feel free to do this as a part of the commit. Comment at: clang/lib/Sema/ParsedAttr.cpp:208 +// The appurtenance rules are applied strictly for all

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm updated this revision to Diff 526600. rsandifo-arm added a comment. Avoid most uses of `<< 0`. Add comments to those that remain. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148702/new/ https://reviews.llvm.org/D148702 Files:

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

erichkeane added a comment. So I have 1 issue that is throughout the patch, but I'm ok with the patch otherwise. This'll get a LGTM after that is fixed. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:2902 S.Diag(AL.getRange().getBegin(),

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm updated this revision to Diff 524846. rsandifo-arm marked an inline comment as done. rsandifo-arm added a comment. Update onto current main. Only change is to replace C++2b with C++23. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm marked an inline comment as done. rsandifo-arm added a comment. Thanks for the reviews! In D148702#4280392 , @erichkeane wrote: > So I don't mind the changes in this stack, though this doing a little bit of > a 'backdoor' way of getting

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

erichkeane added a comment. So I don't mind the changes in this stack, though this doing a little bit of a 'backdoor' way of getting the arm-streaming attribute in rubs me the wrong way. I'm not a huge fan that the solution we've got here only solves THIS problem, and doesn't extend to

[PATCH] D148702: [clang] Add Parse and Sema support for RegularKeyword attributes

rsandifo-arm created this revision. rsandifo-arm added reviewers: erichkeane, aaron.ballman. Herald added subscribers: jdoerfert, kristof.beyls, dschuff. Herald added a project: All. rsandifo-arm requested review of this revision. Herald added subscribers: cfe-commits, aheejin. Herald added a