Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

This revision was automatically updated to reflect the committed changes. Closed by commit rL254670: [PowerPC] Fix calculating address of arguments on stack for variadic func (authored by petarj). Changed prior to commit: http://reviews.llvm.org/D14871?vs=41613=41826#toc Repository: rL LLVM

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

spetrovic updated this revision to Diff 41613. spetrovic marked an inline comment as done. http://reviews.llvm.org/D14871 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/ppc-varargs-struct.c test/CodeGen/x86_64-arguments.c Index: test/CodeGen/x86_64-arguments.c

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

rjmccall added a comment. Please feel free to commit after you make this last change. Comment at: lib/CodeGen/TargetInfo.cpp:216 @@ +215,3 @@ + } + else { +Addr = Address(Ptr, SlotSize); LLVM code style is to put the else on the same line as the closing

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

spetrovic updated this revision to Diff 41498. spetrovic marked 3 inline comments as done. http://reviews.llvm.org/D14871 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/ppc-varargs-struct.c test/CodeGen/x86_64-arguments.c Index: test/CodeGen/x86_64-arguments.c

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

rjmccall added a comment. Thank you. A few more style complaints; with those fixed, LGTM. Comment at: lib/CodeGen/TargetInfo.cpp:166 @@ +165,3 @@ +// Dynamically round a pointer up to a multiple of the given alignment. +static llvm::Value*

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

spetrovic updated this revision to Diff 41297. spetrovic marked 2 inline comments as done. http://reviews.llvm.org/D14871 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/ppc-varargs-struct.c test/CodeGen/x86_64-arguments.c Index: test/CodeGen/x86_64-arguments.c

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

spetrovic added a comment. Comments addressed. http://reviews.llvm.org/D14871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

spetrovic updated the summary for this revision. spetrovic updated this revision to Diff 41142. spetrovic marked 4 inline comments as done. http://reviews.llvm.org/D14871 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/ppc-varargs-struct.c Index: test/CodeGen/ppc-varargs-struct.c

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

rjmccall added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:241 @@ +240,3 @@ + return Address(PtrAsInt, Align); +} + Thank you for extracting this. First, this function deserves a doc comment now; I would suggest: /// Dynamically round a pointer

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

spetrovic updated this revision to Diff 40915. spetrovic marked an inline comment as done. http://reviews.llvm.org/D14871 Files: lib/CodeGen/TargetInfo.cpp test/CodeGen/ppc-varargs-struct.c Index: test/CodeGen/ppc-varargs-struct.c

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

rjmccall added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:3548 @@ +3547,3 @@ +llvm::Value *OverflowArgArea = OverflowArea.getPointer(); +uint32_t Align = CGF.getContext().getTypeAlignInChars(Ty).getQuantity(); +if (Align > 4) { This patch

Re: [PATCH] D14871: [Power PC] fix calculating address of arguments on stack for variadic functions

hfinkel added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:3547 @@ +3546,3 @@ +// Round up address of argument to alignment +llvm::Value *overflow_arg_area = OverflowArea.getPointer(); +uint32_t Align =