[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG921b45a855f0: [Sema]Select correct lexical context during template instantiate (authored by HerrCai0907). Repository: rG LLVM Github Monorepo CHA

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

erichkeane accepted this revision. erichkeane added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3598 + FD->isDefined(FDFriend, true) && + FDFriend->getFriendObjectKind() != Decl::FriendObjectKind

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

tahonermann added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3598 + FD->isDefined(FDFriend, true) && + FDFriend->getFriendObjectKind() != Decl::FriendObjectKind::FOK_None) { +// if Function defined by inline friend, use inline fried as Dec

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3598 + FD->isDefined(FDFriend, true) && + FDFriend->getFriendObjectKind() != Decl::FriendObjectKind::FOK_None) { +// if Function defined by inline friend, use inline fried as Decl

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 updated this revision to Diff 517019. HerrCai0907 added a comment. change LexicalDeclContext Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149009/new/ https://reviews.llvm.org/D149009 Files: clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3598 + FD->isDefined(FDFriend, true) && + FDFriend->getFriendObjectKind() != Decl::FriendObjectKind::FOK_None) { +// if Function defined by inline friend, use inline fried as Dec

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3598 + FD->isDefined(FDFriend, true) && + FDFriend->getFriendObjectKind() != Decl::FriendObjectKind::FOK_None) { +// if Function defined by inline friend, use inline fried as Decl

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 updated this revision to Diff 516615. HerrCai0907 added a comment. add comment and more test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149009/new/ https://reviews.llvm.org/D149009 Files: clang/lib/Sema/SemaTemplateDeduction.cpp

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3598 + FD->isDefined(FDFriend, true) && + FDFriend->getFriendObjectKind() != Decl::FriendObjectKind::FOK_None) { +// if Function defined by inline friend, use inline fried as Dec

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

erichkeane added a comment. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:3597 + if (FD->getFriendObjectKind() == Decl::FriendObjectKind::FOK_None && + FD->isDefined(FDFriend, true) && + FDFriend->getFriendObjectKind() != Decl::FriendObjectKind::FOK_None) { -

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 updated this revision to Diff 516152. HerrCai0907 added a comment. fix assert failed Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149009/new/ https://reviews.llvm.org/D149009 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/l

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 updated this revision to Diff 516151. HerrCai0907 added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149009/new/ https://reviews.llvm.org/D149009 Files: clang/lib/Sema/SemaTemplateDeduction.cpp clang/test/SemaTem

[PATCH] D149009: [Sema]Select correct lexical context during template instantiate

HerrCai0907 created this revision. HerrCai0907 added reviewers: aaron.ballman, erichkeane, shafik. Herald added a project: All. HerrCai0907 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch wants to fix inline friend decl like t