[PATCH] D149028: [Clang] Always pass `-fconvergent-functions` for GPU targets

2023-04-23 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 added a comment. In D149028#4290831 , @JonChesterfield wrote: > I think this is sensible. Passing fno-convergent-functions presumably changes > the default? > > I wonder if we should adopt this and then remove the checks for each of the > GPU

[PATCH] D149028: [Clang] Always pass `-fconvergent-functions` for GPU targets

2023-04-23 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. I think this is sensible. Passing fno-convergent-functions presumably changes the default? I wonder if we should adopt this and then remove the checks for each of the GPU programming models Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D149028: [Clang] Always pass `-fconvergent-functions` for GPU targets

2023-04-23 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 updated this revision to Diff 516198. jhuber6 added a comment. Herald added subscribers: mattd, asavonic. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149028/new/ https://reviews.llvm.org/D149028 Files:

[PATCH] D149028: [Clang] Always pass `-fconvergent-functions` for GPU targets

2023-04-23 Thread Joseph Huber via Phabricator via cfe-commits
jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, jdoerfert, tianshilei1992, tra, yaxunl. Herald added a subscriber: kosarev. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. GPU