[PATCH] D149210: [IR] Change shufflevector undef mask to poison

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8b56da5e9f3b: [IR] Change shufflevector undef mask to poison (authored by ManuelJBrito). Changed prior to commit:

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM assuming tests pass. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149210/new/ https://reviews.llvm.org/D149210

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

ManuelJBrito updated this revision to Diff 517150. ManuelJBrito added a comment. Split patch into print update and internal representation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149210/new/ https://reviews.llvm.org/D149210 Files:

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

ManuelJBrito added a comment. In D149210#4298124 , @nikic wrote: > Could you please split the change to printing + the test updates from all the > other changes? The code changes get lost in the large diff. Yes, that makes sense. The internal

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

nikic requested changes to this revision. nikic added a comment. This revision now requires changes to proceed. Could you please split the change to printing + the test updates from all the other changes? The code changes get lost in the large diff. Comment at:

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

LiDongjin added inline comments. Comment at: llvm/include/llvm-c/Core.h:4088 * \returns a constant that specifies that the result of a \c ShuffleVectorInst * is undefined. */ undefined to poison Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D149210: [IR] Change shufflevector undef mask to poison

ManuelJBrito created this revision. ManuelJBrito added reviewers: aqjune, efriedma, RKSimon, nikic, nlopes, spatel. Herald added a reviewer: deadalnix. Herald added subscribers: luke, kosarev, StephenFan, frasercrmck, okura, kuter, lebedev.ri, kerbowa, luismarques, apazos, sameer.abuasal,