[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:169 -std::vector generateMissingIncludeDiagnostics( +using MissingIncludeEdits = llvm::MapVector; +MissingIncludeEdits generateMissingIncludeEdits( kadircet wrote: > what do

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein updated this revision to Diff 532117. hokein marked 2 inline comments as done. hokein added a comment. rebase, and address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149437/new/ https://reviews.llvm.org/D149437 Files:

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

kadircet added a comment. thanks, mostly LG. I think we need to be a little careful when generating insertions for all the missing includes though. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:169 -std::vector generateMissingIncludeDiagnostics( +using

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein added a comment. I have polished the implementation about the fix-all for missing-include diagnostics, please take a look on the new code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149437/new/ https://reviews.llvm.org/D149437

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein updated this revision to Diff 522067. hokein marked 3 inline comments as done. hokein added a comment. Herald added a subscriber: mgrang. address comments and polish implementations. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149437/new/

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:550 std::optional FixAll; if (RemoveAllUnused && AddAllMissing) FixAll = fixAll(*RemoveAllUnused, *AddAllMissing); kadircet wrote: > sorry for missing it during last

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

kadircet added inline comments. Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:445 -Fix removeAllUnusedIncludes(llvm::ArrayRef UnusedIncludes) { +Fix removeAllUnusedIncludes(llvm::ArrayRef UnusedIncludes, +llvm::StringRef Code) {

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein added a comment. VSCode UI: - missing-include F27261997: image.png - unused-include F27262002: image.png Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149437/new/

[PATCH] D149437: [clangd] Emit ChangeAnnotation label and description for include-cleaner diagnostics.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github