[PATCH] D149694: [Clang] Update warning on some designator initializer cases involving unions

2023-05-08 Thread Shafik Yaghmour via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG96bc78631f16: [Clang] Update warning on some designator initializer cases involving unions (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D149694: [Clang] Update warning on some designator initializer cases involving unions

2023-05-05 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik updated this revision to Diff 519960. shafik added a comment. - Apply clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149694/new/ https://reviews.llvm.org/D149694 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaInit.cpp

[PATCH] D149694: [Clang] Update warning on some designator initializer cases involving unions

2023-05-03 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I think this looks right, and is consistent with guidance from the bug report. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149694/new/ https://reviews.llvm.org/D149694

[PATCH] D149694: [Clang] Update warning on some designator initializer cases involving unions

2023-05-02 Thread Shafik Yaghmour via Phabricator via cfe-commits
shafik created this revision. shafik added reviewers: rsmith, aaron.ballman, erichkeane. Herald added a project: All. shafik requested review of this revision. Currently when using designated initializers in C++ we have a few extension. Two extension which are dangerous involved assigning to