This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb864592915ae: [clang][Interp] Fix ignoring TypeTraitExprs
(authored by tbaeder).
Changed prior to commit:
https://reviews.llvm.org/D149834?vs=5203
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149834/new/
https://reviews.llvm.org/D149834
___
cfe-commits mailing lis
tbaeder updated this revision to Diff 520340.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149834/new/
https://reviews.llvm.org/D149834
Files:
clang/lib/AST/Interp/ByteCodeExprGen.cpp
clang/test/AST/Interp/literals.cpp
Index: clang/test/AST/Interp/literals.cpp
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:875
1 ? 0 : 1;
+sizeof(A);
+alignof(A);
tbaeder wrote:
> tbaeder wrote:
> > aaron.ballman wrote:
> > > tbaeder wrote:
> > > > aaron.ballman wrote:
> > > > > Let's make sure
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:875
1 ? 0 : 1;
+sizeof(A);
+alignof(A);
tbaeder wrote:
> aaron.ballman wrote:
> > tbaeder wrote:
> > > aaron.ballman wrote:
> > > > Let's make sure we still reject this:
>
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:875
1 ? 0 : 1;
+sizeof(A);
+alignof(A);
aaron.ballman wrote:
> tbaeder wrote:
> > aaron.ballman wrote:
> > > Let's make sure we still reject this:
> > > ```
> > > constexpr
aaron.ballman added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:875
1 ? 0 : 1;
+sizeof(A);
+alignof(A);
tbaeder wrote:
> aaron.ballman wrote:
> > Let's make sure we still reject this:
> > ```
> > constexpr int oh_my() {
> > int
tbaeder added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:875
1 ? 0 : 1;
+sizeof(A);
+alignof(A);
aaron.ballman wrote:
> Let's make sure we still reject this:
> ```
> constexpr int oh_my() {
> int x = 0;
> sizeof(int[x++]); //
aaron.ballman added inline comments.
Comment at: clang/test/AST/Interp/literals.cpp:875
1 ? 0 : 1;
+sizeof(A);
+alignof(A);
Let's make sure we still reject this:
```
constexpr int oh_my() {
int x = 0;
sizeof(int[x++]); // This would usually be ev
tbaeder created this revision.
tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://revi
10 matches
Mail list logo
