[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3401a5f7584a: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and… (authored by TIFitis). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 530508. TIFitis marked 4 inline comments as done. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files:

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. If this passes all our tests, it looks fine. A few nits below, try to address if possible. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4427 +

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis added a comment. Ping for review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 523340. TIFitis added a comment. Rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis marked 3 inline comments as done. TIFitis added a comment. Ping for review :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 ___ cfe-commits mailing

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 520730. TIFitis added a comment. Addressed reviewer comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

jsjodin added inline comments. Comment at: llvm/lib/Frontend/OpenMP/OMPIRBuilder.cpp:4376 +function_ref CustomMapperCB) { + auto EmitNonContiguousDescriptor = [&]() { +MapInfosTy::StructNonContiguousInfo = I don't think we need a lambda function, it

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis updated this revision to Diff 519822. TIFitis added a comment. Changed std::function to llvm::function_ref for the callbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149872/new/ https://reviews.llvm.org/D149872 Files:

[PATCH] D149872: [OpenMP][OMPIRBuilder] Migrate emitOffloadingArrays and EmitNonContiguousDescriptor from Clang

TIFitis created this revision. TIFitis added reviewers: jdoerfert, jsjodin. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. TIFitis requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, jplehr, sstefan1. Herald added