This revision was automatically updated to reflect the committed changes.
Closed by commit rG89d5635f0a83: [lld][WebAssembly] Add --keep-section flag
(authored by sbc100).
Changed prior to commit:
https://reviews.llvm.org/D149917?vs=557960&id=557993#toc
Repository:
rG LLVM Github Monorepo
C
dschuff accepted this revision.
dschuff added a comment.
otherwise LGTM
Comment at: lld/wasm/Options.td:196
+defm keep_section: Eq<"keep-section",
+ "Preserve a section even when --strip-all is given. This is useful for
compiler drivers such as clang or emcc that, for e
sbc100 added a comment.
PTAL
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149917/new/
https://reviews.llvm.org/D149917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
sbc100 updated this revision to Diff 557960.
sbc100 added a comment.
- feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149917/new/
https://reviews.llvm.org/D149917
Files:
clang/lib/Driver/ToolChains/WebAssembly.cpp
lld/test/wasm/strip-a
sbc100 updated this revision to Diff 557959.
sbc100 marked an inline comment as done.
sbc100 added a comment.
- feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149917/new/
https://reviews.llvm.org/D149917
Files:
clang/lib/Driver/ToolChain
sbc100 updated this revision to Diff 557958.
sbc100 marked an inline comment as done.
sbc100 added a comment.
- feedback
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149917/new/
https://reviews.llvm.org/D149917
Files:
clang/lib/Driver/ToolChain
dschuff added inline comments.
Comment at: lld/wasm/Options.td:196
+defm keep_section: Eq<"keep-section",
+ "Preserve a section even when --strip-all is given. This is useful for
compiler drivers such as clang or emcc that, for example, depend on the
features section for
kripken requested changes to this revision.
kripken added inline comments.
This revision now requires changes to proceed.
Comment at: clang/lib/Driver/ToolChains/WebAssembly.cpp:154
+ if (!WasmOptPath.empty()) {
+CmdArgs.push_back("--keep-secton=target_features");
+ }
-
