This revision was automatically updated to reflect the committed changes.
Closed by commit rG8afd831b456a: ms inline asm: recognize case-insensitive JMP
and CALL as TargetLowering… (authored by MaskRay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149920/new/
https://reviews.llvm.org/D149920
MaskRay updated this revision to Diff 519744.
MaskRay marked an inline comment as done.
MaskRay added a comment.
fix a typo in a comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D149920/new/
https://reviews.llvm.org/D149920
Files:
clang/test
pengfei added inline comments.
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:33955
const SmallVectorImpl &AsmStrs, unsigned OpNo) const {
- StringRef InstrStr = getInstrStrFromOpNo(AsmStrs, OpNo);
-
- if (InstrStr.contains("call"))
-return true;
-
- return false
MaskRay updated this revision to Diff 519734.
MaskRay retitled this revision from "ms inline asm: recognize "jmp" as
TargetLowering::C_Address" to "ms inline asm: recognize case-insensitive JMP
and CALL as TargetLowering::C_Address".
MaskRay edited the summary of this revision.
MaskRay added a co
