[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

ziqingluo-90 abandoned this revision. ziqingluo-90 added a comment. In D150338#4503802 , @ziqingluo-90 wrote: > Re-landed in `a07a6f6c74a03405eccdcd3832acb2187d8b9c21` > > Moved the use of `clang::Sema` from `UnsafeBufferAnalysis` to >

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

NoQ added a comment. Looks like the patch has landed, let's close the revision? 樂 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150338/new/ https://reviews.llvm.org/D150338 ___ cfe-commits mailing list

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

ziqingluo-90 added a comment. Re-landed in `a07a6f6c74a03405eccdcd3832acb2187d8b9c21` Moved the use of `clang::Sema` from `UnsafeBufferAnalysis` to `AnalysisBasedWarnings`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150338/new/

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

ziqingluo-90 added a comment. In D150338#4502885 , @chapuni wrote: > Excuse me, I have reverted this due to circular deps. > `clangAnalysis` should not depend on `clangSema`. Thank you @chapuni , I will fix it soon. Repository: rG LLVM Github

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

chapuni reopened this revision. chapuni added a comment. This revision is now accepted and ready to land. Excuse me, I have reverted this due to circular deps. `clangAnalysis` should not depend on `clangSema`. Comment at:

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5b012bf5ab5f: [-Wunsafe-buffer-usage] Improving insertion of the [[clang… (authored by ziqingluo-90). Repository: rG LLVM Github Monorepo

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

ziqingluo-90 updated this revision to Diff 540548. ziqingluo-90 added a comment. rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150338/new/ https://reviews.llvm.org/D150338 Files: clang/include/clang/Analysis/Analyses/UnsafeBufferUsage.h

[PATCH] D150338: [-Wunsafe-buffer-usage] Improving insertion of the [[clang::unsafe_buffer_usage]] attribute

NoQ accepted this revision. NoQ added a comment. This revision is now accepted and ready to land. Looks good to me! This doesn't take care of the GNU syntax (`__attribute__((unsafe_buffer_usage))`), but this probably isn't a big deal as people can simply use the modern C++ syntax in any code