[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

2023-05-15 Thread Martin Böhme via Phabricator via cfe-commits
mboehme added a subscriber: amyk. mboehme added a comment. In D150352#4342480 , @uabelho wrote: > Hello, > > > ../../clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:43:27: > error: 'build' is deprecated: Use the version that

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

2023-05-15 Thread Mikael Holmén via Phabricator via cfe-commits
uabelho added a comment. Hello, ../../clang-tools-extra/clang-tidy/bugprone/UncheckedOptionalAccessCheck.cpp:43:27: error: 'build' is deprecated: Use the version that takes a const Decl & instead [-Werror,-Wdeprecated-declarations] ControlFlowContext::build(, *FuncDecl.getBody(),

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

2023-05-15 Thread Martin Böhme via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1a42f795587b: [clang][dataflow] Dont analyze templated declarations. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

2023-05-15 Thread Martin Böhme via Phabricator via cfe-commits
mboehme updated this revision to Diff 522096. mboehme added a comment. Spell `-fno-delayed-template-parsing` correctly (it was missing a hyphen). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/ https://reviews.llvm.org/D150352 Files:

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

2023-05-15 Thread Martin Böhme via Phabricator via cfe-commits
mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:2537 -TEST(TransferTest, DerefDependentPtr) { std::string Code = R"( mboehme wrote: > gribozavr2 wrote: > > This `DerefDependentPtr` test was originally added

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

2023-05-15 Thread Martin Böhme via Phabricator via cfe-commits
mboehme updated this revision to Diff 522075. mboehme added a comment. Set `-fnodelayed-template-parsing` again. This is needed to make tests pass on Windows. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

2023-05-14 Thread Martin Böhme via Phabricator via cfe-commits
mboehme updated this revision to Diff 522040. mboehme added a comment. Eliminate warnings for calling deprecated functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/ https://reviews.llvm.org/D150352 Files:

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

2023-05-14 Thread Martin Böhme via Phabricator via cfe-commits
mboehme updated this revision to Diff 522036. mboehme marked an inline comment as done. mboehme added a comment. Eliminate warning for use of deprecated function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

2023-05-12 Thread Martin Böhme via Phabricator via cfe-commits
mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:36 + /// `S` resides. `D.isTemplated()` must be false. + static llvm::Expected build(const Decl , Stmt , +

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

2023-05-12 Thread Martin Böhme via Phabricator via cfe-commits
mboehme updated this revision to Diff 521603. mboehme added a comment. Changes in response to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150352/new/ https://reviews.llvm.org/D150352 Files:

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

2023-05-11 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TransferTest.cpp:2537 -TEST(TransferTest, DerefDependentPtr) { std::string Code = R"( This `DerefDependentPtr` test was originally added in

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

2023-05-11 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/ControlFlowContext.h:36 + /// `S` resides. `D.isTemplated()` must be false. + static llvm::Expected build(const Decl , Stmt , +

[PATCH] D150352: [clang][dataflow] Don't analyze templated declarations.

2023-05-11 Thread Martin Böhme via Phabricator via cfe-commits
mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Attempting to analyze templated code doesn't