[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGd93bdd8bd52a: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate… (authored by domada). Changed prior to commit: https://reviews.llvm.org/D150354?vs=522999=523732#toc Repository: rG

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. Target-related constructs came in as part of OpenMP 4.0. Would you want to have a different default for the device version? CHANGES SINCE LAST ACTION

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada added a comment. In D150354#4348785 , @kiranchandramohan wrote: > In D150354#4342146 , @domada wrote: > >> In D150354#4337148 , @awarzynski >> wrote: >> >>> All

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada updated this revision to Diff 522999. domada added a comment. Change the default version of OpenMP version flag to 1.1 for flang. Modify the flag description text. No changes for Clang code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150354/new/

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

kiranchandramohan added a comment. In D150354#4342146 , @domada wrote: > In D150354#4337148 , @awarzynski > wrote: > >> All in all LGTM, but I'm not sure whether Flang should be defaulting to >> OpenMP 5.0.

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada added a comment. In D150354#4337148 , @awarzynski wrote: > All in all LGTM, but I'm not sure whether Flang should be defaulting to > OpenMP 5.0. AFAIK, that's not supported yet. If you wish I can set to OpenMP 4.5. But then we need to have two

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada updated this revision to Diff 522157. domada added a comment. Patch rebased because I applied remarks for parent revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150354/new/ https://reviews.llvm.org/D150354 Files: clang/include/clang/Driver/Options.td

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

awarzynski added a comment. All in all LGTM, but I'm not sure whether Flang should be defaulting to OpenMP 5.0. AFAIK, that's not supported yet. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:34 + Args.AddAllArgs(CmdArgs, {options::OPT_ffixed_form, +

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada updated this revision to Diff 521282. domada added a comment. Patch rebased + clang format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150354/new/ https://reviews.llvm.org/D150354 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada updated this revision to Diff 521251. domada added a comment. Patch rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150354/new/ https://reviews.llvm.org/D150354 Files: clang/include/clang/Driver/Options.td clang/lib/Driver/ToolChains/Flang.cpp

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada created this revision. domada added reviewers: kiranchandramohan, kiranktp, dpalermo, NimishMishra, skatrak, agozillon, raghavendhra. domada added projects: Flang, OpenMP, MLIR. Herald added subscribers: bviyer, sunshaoce, Moerafaat, zero9178, bzcheeseman, sdasgup3, wenzhicui, wrengr,