[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd02984519ab: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder (authored by jhuber6). Repository: rG LLVM Github

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

gchatelet added a comment. In D150461#4338499 , @jhuber6 wrote: > In D150461#4338498 , @gchatelet > wrote: > >> quick question, did you try to build the openmp runtime as well to check if >> the tests still

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

jhuber6 added a comment. In D150461#4338498 , @gchatelet wrote: > quick question, did you try to build the openmp runtime as well to check if > the tests still pass? I'm an OpenMP developer so I always have it built : ). Yes they still pass.

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

gchatelet added a comment. quick question, did you try to build the openmp runtime as well to check if the tests still pass? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150461/new/ https://reviews.llvm.org/D150461

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

gchatelet accepted this revision. gchatelet added a comment. You beat me to it :) Thx for the fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150461/new/ https://reviews.llvm.org/D150461 ___

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150461/new/ https://reviews.llvm.org/D150461

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

jhuber6 created this revision. jhuber6 added reviewers: jdoerfert, tianshilei1992, ABataev, JonChesterfield, tstellar, gchatelet. Herald added subscribers: sunshaoce, guansong, hiraditya, yaxunl. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: