This revision was automatically updated to reflect the committed changes.
Closed by commit rGa72b064acf95: [clang-format] Handle chrono ud
suffixes in IntegerLiteralSeparator (authored by owenpan).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
owenpan updated this revision to Diff 522397.
owenpan added a comment.
Addressed the review comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150539/new/
https://reviews.llvm.org/D150539
Files:
clang/lib/Format/IntegerLiteralSeparatorFixer.cpp
owenpan added inline comments.
Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:116-117
if (Style.isCpp()) {
- if (const auto Pos = Text.find_first_of("_i"); Pos != StringRef::npos) {
+ // FIXME: This doesn't work for ud-suffix d from
HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Format/IntegerLiteralSeparatorFixer.cpp:116-117
if (Style.isCpp()) {
- if (const auto Pos =
owenpan created this revision.
Herald added projects: All, clang, clang-format.
Herald added a subscriber: cfe-commits.
Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay.
owenpan requested review of this revision.
Fixes https://github.com/llvm/llvm-project/issues/62679.