[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

xry111 added a comment. Hmm, I'd tested the change before creating this but it seems those tests are "UNSUPPORTED" on my system :(. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150582/new/ https://reviews.llvm.org/D150582

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

thesamesam added a comment. Sure & thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150582/new/ https://reviews.llvm.org/D150582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

kadircet added a comment. This broke buildbots because `compile_commands.json` being `empty` has other consequences. Fixing forward in 9ffef0f24de0fc05b946e662a7b233a32ad058e3

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4ddae8b94139: [clangd] Fix test failure when its built with compiler flags unknown by clang (authored by xry111, committed by thesamesam).

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

thesamesam accepted this revision. thesamesam added a comment. This revision is now accepted and ready to land. (I even struggled to find docs for the fix we used for clang-tidy, although it obviously works.) Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150582: [clangd] Fix test failure when it's built with compiler flags unknown by clang

xry111 created this revision. xry111 added reviewers: thesamesam, MaskRay, uabelho. Herald added subscribers: kadircet, arphaman. Herald added a project: All. xry111 requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. Herald added a project: clang-tools-extra.