[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mboehme marked an inline comment as done. Closed by commit rG5a16665ed535: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp. (authored by

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:717-723 +Value *SubExprVal = Env.getValueStrict(*SubExpr); +if (SubExprVal == nullptr) return; -Env.setStorageLocation(*S,

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme updated this revision to Diff 523031. mboehme added a comment. Renamed `forward...` functions to `propagate...`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150655/new/ https://reviews.llvm.org/D150655 Files:

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr , const Expr , Environment ) { + if (auto *Val = Env.getValueStrict(From)) mboehme wrote: >

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

xazax.hun accepted this revision. xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:717-723 +Value *SubExprVal = Env.getValueStrict(*SubExpr); +if (SubExprVal == nullptr) return; -Env.setStorageLocation(*S,

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr , const Expr , Environment ) { + if (auto *Val = Env.getValueStrict(From)) sammccall

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:751-752 +Env.setValue(Loc, *Val); +} else { + if (Value *Val = Env.createValue(S->getType())) +Env.setValueStrict(*S,

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme updated this revision to Diff 522583. mboehme added a comment. Simplified `else { if {} }` to `else if {}`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150655/new/ https://reviews.llvm.org/D150655 Files:

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr , const Expr , Environment ) { + if (auto *Val = Env.getValueStrict(From)) mboehme wrote: > ymandel wrote: > > mboehme wrote: >

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr , const Expr , Environment ) { + if (auto *Val = Env.getValueStrict(From)) ymandel wrote: > mboehme wrote: > > sammccall wrote: >

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr , const Expr , Environment ) { + if (auto *Val =

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr , const Expr , Environment ) { + if (auto *Val = Env.getValueStrict(From)) sammccall wrote: > the name "forward" isn't clear to

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr , const Expr , Environment ) { + if (auto *Val = Env.getValueStrict(From)) the name "forward" isn't clear to me - if anything

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch handles the straightforward cases.