[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

2023-05-19 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu added a comment. In D150817#4356305 , @TWeaver wrote: > Hello and good afternoon from the UK, > > I believe this patch has caused failures on the following buildbot: > > https://lab.llvm.org/buildbot/#/builders/216/builds/21493 > > are you able

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

2023-05-19 Thread Tom Weaver via Phabricator via cfe-commits
TWeaver added a comment. Hello and good afternoon from the UK, I believe this patch has caused failures on the following buildbot: https://lab.llvm.org/buildbot/#/builders/216/builds/21493 are you able to take a look? thanks, Tom W Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

2023-05-19 Thread Zequan Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75993812d5c1: Use windows baskslash on anonymous tag locations if using MSVCFormatting and… (authored by zequanwu). Changed prior to commit:

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

2023-05-19 Thread Hans Wennborg via Phabricator via cfe-commits
hans accepted this revision. hans added a comment. Nice! lgtm Comment at: clang/lib/AST/TypePrinter.cpp:1391 + WrittenFile = Callbacks->remapPath(File); +// The following tries to fix inconsistent path separator created by +//

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

2023-05-18 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150817/new/ https://reviews.llvm.org/D150817 ___

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

2023-05-17 Thread Zequan Wu via Phabricator via cfe-commits
zequanwu created this revision. zequanwu added a reviewer: hans. Herald added a project: All. zequanwu requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes a nondeterminism on debug info when building on windows natively vs cross