[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

porglezomp added a comment. Confirming your sense that those loops look a bit suspicious, I've found that this makes some implicit conversions ambiguous. Put a test case up for that at D151532 , I think I understand what those loops should be changed to

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9041-9044 + // (allowing splatting the scalar to a vector). + for (unsigned Candidate = 0; Candidate < 2; ++Candidate) { +for (QualType Vec1Ty :

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

porglezomp added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9041-9044 + // (allowing splatting the scalar to a vector). + for (unsigned Candidate = 0; Candidate < 2; ++Candidate) { +for (QualType Vec1Ty :

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

aaron.ballman added a comment. Thanks for the fix! The changes should come with a release note. Comment at: clang/lib/Sema/SemaOverload.cpp:9041-9044 + // (allowing splatting the scalar to a vector). + for (unsigned Candidate = 0; Candidate < 2; ++Candidate) { +

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

porglezomp updated this revision to Diff 524432. porglezomp added a comment. Rebasing onto modified tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151060/new/ https://reviews.llvm.org/D151060 Files: clang/lib/Sema/SemaOverload.cpp

[PATCH] D151060: [Clang][Sema] Generate vector vs scalar builtin overloads

porglezomp created this revision. porglezomp added reviewers: aaron.ballman, fhahn. Herald added a subscriber: StephenFan. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The bit-shifting operator