[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

2023-05-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D151092#4368225 , @courbet wrote: > In D151092#4368151 , @aaron.ballman > wrote: > >> The release note references documentation that doesn't exist, so Sphinx is >> failing: http

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

2023-05-24 Thread Clement Courbet via Phabricator via cfe-commits
courbet added a comment. In D151092#4368151 , @aaron.ballman wrote: > The release note references documentation that doesn't exist, so Sphinx is > failing: https://lab.llvm.org/buildbot/#/builders/115/builds/46942 Sorry, fixed in rG62dc3ba8442f

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

2023-05-24 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. The release note references documentation that doesn't exist, so Sphinx is failing: https://lab.llvm.org/buildbot/#/builders/115/builds/46942 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151092/new/ https://reviews.

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

2023-05-24 Thread Clement Courbet via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9182c679dde7: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&`… (authored by courbet). Repository: rG LLVM Github Mono

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

2023-05-22 Thread Clement Courbet via Phabricator via cfe-commits
courbet updated this revision to Diff 524288. courbet marked 2 inline comments as done. courbet added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151092/new/ https://reviews.llvm.org/D151092 Files: clang-tool

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

2023-05-22 Thread Eugene Zelenko via Phabricator via cfe-commits
Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:385 +- Improved :doc:`performance-no-automatic-move + `: warn on `const &&` + constructors. Please use double back-ticks for `const &&`. Comment at: c

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

2023-05-22 Thread Clement Courbet via Phabricator via cfe-commits
courbet updated this revision to Diff 524276. courbet added a comment. fix release note placemenfix release note placement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151092/new/ https://reviews.llvm.org/D151092 Files: clang-tools-extra/clang-

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

2023-05-22 Thread Clement Courbet via Phabricator via cfe-commits
courbet created this revision. courbet added a reviewer: gnanabit. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. courbet requested review of this revision. Herald added a project: clang-tools-extra. We were only handli