[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

HazardyKnusperkeks added a comment. > In D151145#4365580 , > @HazardyKnusperkeks wrote: > >> As stated on Github I don't think we have a bug. > > Are you sure, I'm pretty sure this is a bug? Can you elaborate on the > discussion on github. I wouldn't

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

Icantjuddle added a comment. In D151145#4369406 , @MyDeveloperDay wrote: > We don't normally land broken tests, even if they are disabled, its better > for us if we get a fix at the same time ;-) In D151145#4367495

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

MyDeveloperDay added a comment. We don't normally land broken tests, even if they are disabled, its better for us if we get a fix at the same time ;-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151145/new/ https://reviews.llvm.org/D151145

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

krasimir added a comment. Thank you! That's a bug in the raw string format manager. This code effectively first looks for a matching top-level style, and if that's not found, then it tries to derive one via the RawFormat's BasedOnStyle:

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, rymiel, HazardyKnusperkeks. HazardyKnusperkeks added a comment. As stated on Github I don't think we have a bug. Comment at: clang/unittests/Format/FormatTestRawStrings.cpp:79 +)format"; +llvm::MemoryBufferRef

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

Icantjuddle removed a reviewer: craig.topper. Icantjuddle added a comment. Sorry @craig.topper for some reason `git blame` locally attributed much of the edits to you, doesn't match what I see online at github. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

craig.topper added a comment. I don't think I'm the right reviewer for this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151145/new/ https://reviews.llvm.org/D151145 ___ cfe-commits mailing list

[PATCH] D151145: Add disabled unittest reproducing TextProto formatting issue.

Icantjuddle created this revision. Icantjuddle added a reviewer: clang-format. Herald added a project: All. Icantjuddle requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Github Issue