This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3184fb958091: [clang][Diagnostics] Print empty lines in
multiline snippets (authored by tbaeder).
Repository:
rG LLVM Github Monorepo
CHANGES SIN
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
Comment at: clang/test/Misc/diag-style.cpp:10
+// CHECK-NEXT: {{^}} | ^~~~{{$}}
+// CHECK-NEXT: {{^}}5 | {{$}}
+// CHECK-NEXT:
tbaeder added inline comments.
Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1246
// line from what the user is intended to see.
-if (DiagOpts->ShowSourceRanges) {
+if (DiagOpts->ShowSourceRanges && !SourceLine.empty()) {
SourceLine = ' ' + SourceLine;
---
tbaeder updated this revision to Diff 525050.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151301/new/
https://reviews.llvm.org/D151301
Files:
clang/lib/Frontend/TextDiagnostic.cpp
clang/test/Misc/diag-style.cpp
Index: clang/test/Misc/diag-style.cpp
===
tbaeder added inline comments.
Comment at: clang/test/Misc/diag-style.cpp:10
+// CHECK-NEXT: {{^}} | ^~~~{{$}}
+// CHECK-NEXT: {{^}}5 | {{$}}
+// CHECK-NEXT: {{^}}6 | true, "");{{$}}
Questionable whether the space afte
tbaeder created this revision.
tbaeder added reviewers: clang, cjdb, aaron.ballman.
Herald added a project: All.
tbaeder requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
We should preserve empty lines in output snippets.
Repository:
rG L
