[PATCH] D151373: [libclang] Expose arguments of clang::annotate

aaron.ballman added a comment. In D151373#4578560 , @fridtjof wrote: > It was the unit test I added - I forgot to properly dispose of the EvalResult > there I've re-landed the changes in 177ec17944af5fb87445017c3ac9028bbc1d710f

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

This revision was automatically updated to reflect the committed changes. Closed by commit rG177ec17944af: [libclang] Expose arguments of clang::annotate (authored by fridtjof, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof updated this revision to Diff 549197. fridtjof added a comment. It was the unit test I added - I forgot to properly dispose of the EvalResult there CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373 Files: clang/docs/ReleaseNotes.rst

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

vitalybuka added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:3656 + VisitorWorkList *WL = nullptr; + if (!WorkListFreeList.empty()) { +WL = WorkListFreeList.back(); vitalybuka wrote: > There is a leak here

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

vitalybuka added a comment. Not sure why the similar code above does not leak, so I will revert and leave to author to investigate Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

vitalybuka added inline comments. Comment at: clang/tools/libclang/CIndex.cpp:3656 + VisitorWorkList *WL = nullptr; + if (!WorkListFreeList.empty()) { +WL = WorkListFreeList.back(); There is a leak here

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

This revision was automatically updated to reflect the committed changes. Closed by commit rG5aa06b18940c: [libclang] Expose arguments of clang::annotate (authored by fridtjof, committed by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof added a comment. (Whoops, somehow never got a mail for that reply) Yes, please. You can attribute the commit to "fridtjof " CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373 ___ cfe-commits

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to commit this on your behalf? If so, what name and email address would you like me to use for patch attribution? CHANGES SINCE LAST ACTION

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof updated this revision to Diff 545388. fridtjof added a comment. Whoops, forgot to run clang-format on the last diff. Also took the opportunity to just get rid of the template mess now that we're only dealing with AnnotateAttr anyway. CHANGES SINCE LAST ACTION

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof added a comment. In D151373#4538604 , @aaron.ballman wrote: > I think we should drop the `annotate_type` functionality from the patch > entirely rather than add it without any test coverage knowing it doesn't seem > to work as expected.

[PATCH] D151373: [libclang] Expose arguments of clang::annotate

fridtjof updated this revision to Diff 545305. fridtjof retitled this revision from "[libclang] Expose arguments of clang::annotate{_type}" to "[libclang] Expose arguments of clang::annotate". fridtjof edited the summary of this revision. CHANGES SINCE LAST ACTION

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

aaron.ballman added a comment. In D151373#4533550 , @fridtjof wrote: > I fixed the failing IBOutletCollection.m test - there was code to do special > handling for the respective attribute type, which my patch accidentally > skipped previously. I

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

fridtjof updated this revision to Diff 544142. fridtjof added a comment. I fixed the failing IBOutletCollection.m test - there was code to do special handling for the respective attribute type, which my patch accidentally skipped previously. I reordered the generic attribute handling to come

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

aaron.ballman added a comment. I think precommit CI may have found a relevant failure: TEST 'Clang :: Index/IBOutletCollection.m' FAILED Script: -- : 'RUN: at line 8'; c:\ws\w5\llvm-project\premerge-checks\build\bin\c-index-test.exe

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

fridtjof updated this revision to Diff 530219. fridtjof added a comment. - Deduplicated code by using templates (looks a bit ridicilous though) - Release notes entry added - Unit test added CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151373/new/ https://reviews.llvm.org/D151373

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

aaron.ballman added a comment. Thank you for the additions! This should have test coverage in clang/unitttests/libclang/LibclangTest.cpp and a release note. Comment at: clang/tools/libclang/CIndex.cpp:2745 } +// TODO these two methods are exactly the same. Can this be

[PATCH] D151373: [libclang] Expose arguments of clang::annotate{_type}

fridtjof created this revision. fridtjof added a reviewer: aaron.ballman. Herald added a subscriber: arphaman. Herald added a project: All. fridtjof requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This enables easy consumption of arbitrary