[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

This revision was automatically updated to reflect the committed changes. Closed by commit rGb0bab14b8b53: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch. (authored by balazske). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151431/new/ h

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

balazske updated this revision to Diff 526927. balazske added a comment. removed check name in documentation code comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151431/new/ https://reviews.llvm.org/D151431 Files: clang-tools-extra/clang-t

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

PiotrZSL accepted this revision. PiotrZSL added a comment. In D151431#4376181 , @balazske wrote: > Maybe we can remove the warning in all cases when the type is a POD type (or > add a check option)? **Leave it... **From a user perspective, it doesn't ma

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

balazske added a comment. The case of fully dependent type (`unique_ptr`) is not working in this checker and likely not in `SharedPtrArrayMismatchCheck`. I can fix this in a next patch (for both checkers). Maybe we can remove the warning in all cases when the type is a POD type (or add a check

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

balazske updated this revision to Diff 526063. balazske marked an inline comment as done. balazske added a comment. Fixed the documentation issue. Added tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151431/new/ https://reviews.llvm.org/D1514

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, But: - Align check description before committing. - Consider adding some test with std::unique_ptr behind typedef. - Consider adding test with unique_ptr depend on template argument b

[PATCH] D151431: [clang-tidy] Add check bugprone-unique-ptr-array-mismatch.

balazske created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, steakhal, martong, gamesh411, Szelethus, dkrupp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. balazske requested review of this revision. Herald added a project: clang-tools-extra. Hera