[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6cdc07a701ee: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h (authored by tra). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 accepted this revision. qiongsiwu1 added a comment. In D151503#4381548 , @tra wrote: > @qiongsiwu1 : I've updated the patch. PTAL. LGTM! Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra added a comment. @qiongsiwu1 : I've updated the patch. PTAL. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151503/new/ https://reviews.llvm.org/D151503 ___ cfe-commits mailing list

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra updated this revision to Diff 526697. tra added a comment. Updated according to comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151503/new/ https://reviews.llvm.org/D151503 Files: clang/lib/Headers/CMakeLists.txt Index:

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( tra wrote: > qiongsiwu1 wrote: > > qiongsiwu1 wrote: > > > tra wrote: > > > > qiongsiwu1 wrote: > > > > > Do we need an install

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( qiongsiwu1 wrote: > qiongsiwu1 wrote: > > tra wrote: > > > qiongsiwu1 wrote: > > > > Do we need an install target for

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra updated this revision to Diff 526227. tra added a comment. Verified that install works correctly with individual component installations: cmake -DCOMPONENT=cuda-resource-headers -P ./cmake_install.cmake cmake -DCOMPONENT=clang-resource-headers -P ./cmake_install.cmake Repository: rG

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( qiongsiwu1 wrote: > tra wrote: > > qiongsiwu1 wrote: > > > Do we need an install target for `${cuda_wrapper_bits_files}` for the >

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( tra wrote: > qiongsiwu1 wrote: > > Do we need an install target for `${cuda_wrapper_bits_files}` for the > >

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( qiongsiwu1 wrote: > Do we need an install target for `${cuda_wrapper_bits_files}` for the > `cuda-resource-headers` component as well? It

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

qiongsiwu1 added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:516 COMPONENT cuda-resource-headers) install( Do we need an install target for `${cuda_wrapper_bits_files}` for the `cuda-resource-headers` component as well? It seems to be

[PATCH] D151503: [CUDA] correctly install cuda_wrappers/bits/shared_ptr_base.h

tra created this revision. Herald added subscribers: mattd, carlosgalvezp, bixia, yaxunl. Herald added a project: All. tra edited the summary of this revision. tra edited the summary of this revision. tra published this revision for review. tra added reviewers: qiongsiwu1, jlebar. Herald added a