This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4a16f65fc83d: [Driver][X86] Reject unsupported value for
-mabi= (authored by MaskRay).
Changed prior to commit:
https://reviews.llvm.org/D151509?v
pengfei accepted this revision.
pengfei added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang/test/Driver/x86-mabi.c:6
+
+// CHECK-NOT: {{error|warning}}:
+// ERR: error: unsupported option '-mabi=' for target '{{.*}}'
MaskRa
MaskRay added inline comments.
Comment at: clang/test/Driver/x86-mabi.c:6
+
+// CHECK-NOT: {{error|warning}}:
+// ERR: error: unsupported option '-mabi=' for target '{{.*}}'
pengfei wrote:
> What's the expected result for e.g. `x86_64-pc-windows-gnu/mingw/cygnus`
pengfei added inline comments.
Comment at: clang/test/Driver/x86-mabi.c:6
+
+// CHECK-NOT: {{error|warning}}:
+// ERR: error: unsupported option '-mabi=' for target '{{.*}}'
What's the expected result for e.g. `x86_64-pc-windows-gnu/mingw/cygnus` ?
Repository:
MaskRay created this revision.
MaskRay added reviewers: aaron.ballman, arichardson, craig.topper, erichkeane,
pengfei.
Herald added a project: All.
MaskRay requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
-mabi= was incorrectly claimed befo