[PATCH] D151547: [RISCV] Remove experimental for zihintntl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf808788487ab: [RISCV] Remove experimental for zihintntl (authored by jacquesguan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151547: [RISCV] Remove experimental for zihintntl

jacquesguan updated this revision to Diff 548903. jacquesguan added a comment. Address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang

[PATCH] D151547: [RISCV] Remove experimental for zihintntl

asb accepted this revision. asb added a comment. This revision is now accepted and ready to land. LGTM - just see the very minor corrections inline. Thanks! Comment at: clang/test/Preprocessor/riscv-target-features.c:146 // RUN: %clang -target riscv32-unknown-linux-gnu -men

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan updated this revision to Diff 548848. jacquesguan added a comment. rebase and add release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 Files: clang/include/clang/Basic/BuiltinsRISCV

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

asb added a comment. @jacquesguan: I think this is good to go if you rebase now D156221 landed and add a release note. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 _

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

asb added a comment. In D151547#4531062 , @jacquesguan wrote: > https://github.com/riscv-non-isa/riscv-c-api-doc/pull/47 is already merged, > any more advice about this patch? Just that it needs a release note, and we need the newly defined overloaded

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan added a comment. https://github.com/riscv-non-isa/riscv-c-api-doc/pull/47 is already merged, any more advice about this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

asb added a comment. @jacquesguan yes I agree, let's hold off on merging this until that PR is merged as it looks like it's quite close. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 __

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

BeMg added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan added a comment. In D151547#4514424 , @asb wrote: > I remain concerned about exposing the intrinsics if they're not yet agreed as > finalised. I see there is now a PR to add them to riscv-c-api doc > https://github.com/riscv-non-isa/riscv-c-

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan updated this revision to Diff 542290. jacquesguan marked 2 inline comments as done. jacquesguan added a comment. rebase main and address comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

asb added a comment. I remain concerned about exposing the intrinsics if they're not yet agreed as finalised. I see there is now a PR to add them to riscv-c-api doc https://github.com/riscv-non-isa/riscv-c-api-doc/pull/47 I'd be OK with merging this now if the intrinsics were temporarily remove

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

BeMg added inline comments. Comment at: llvm/unittests/Support/RISCVISAInfoTest.cpp:376 EXPECT_EQ(Exts.count("zihintntl"), 1U); - auto MaybeISAInfo2 = RISCVISAInfo::parseArchString("rv64izihintntl0p2", true); + auto MaybeISAInfo2 = RISCVISAInfo::parseArchString("rv64izihint

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan marked 2 inline comments as done. jacquesguan added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:151 // RUN: -o - | FileCheck --check-prefix=CHECK-ZIHINTNTL-EXT %s // CHECK-ZIHINTNTL-EXT: __riscv_zihintntl 2000{{$}}

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan updated this revision to Diff 541904. jacquesguan added a comment. Address comment and rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 Files: clang/include/clang/Basic/BuiltinsRISCV.

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

BeMg added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:151 // RUN: -o - | FileCheck --check-prefix=CHECK-ZIHINTNTL-EXT %s // CHECK-ZIHINTNTL-EXT: __riscv_zihintntl 2000{{$}} The CHECK-ZIHINTNTL-EXT also need update. Reposito

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

BeMg added inline comments. Comment at: llvm/docs/RISCVUsage.rst:214 +``zihintntl`` LLVM implements the `0.2 draft specification `__. zihintntl could add into `table:: Ratified E

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan added a comment. Herald added a subscriber: wangpc. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

asb added a comment. @jacquesguan I'm not sure on the standardisation process or status for these intrinsics. Perhaps @kito-cheng has an idea? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/new/ https://reviews.llvm.org/D151547

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan added a comment. In D151547#4375613 , @asb wrote: > Thanks for the patch. > > Is the __riscv_ntl_* interface finalised and agreed? I'm wary of repeating > the mistake we made with the V extension where we exposed intrinsics that > weren't ye

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

asb added a comment. Is the __riscv_ntl_* interface finalised and agreed? I'm wary of repeating the mistake we made with the V extension where we exposed intrinsics that weren't yet finalised. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151547/n

[PATCH] D151547: [RISCV] Remove experimental for zihintntl.

jacquesguan created this revision. jacquesguan added reviewers: craig.topper, asb, luismarques, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, jdoerfert, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, ed