This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG85af42df5dbb: [lld] add context-sensitive PGO options for
MachO (authored by ellis).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST
ellis updated this revision to Diff 527205.
ellis added a comment.
Fix paths in clang test to support windows
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151589/new/
https://reviews.llvm.org/D151589
Files:
ellis updated this revision to Diff 526825.
ellis marked 3 inline comments as not done.
ellis added a comment.
Rename test function to `foo` since `_start` is not a necessary symbol
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151589/new/
int3 added inline comments.
Comment at: lld/test/MachO/cspgo-gen.ll:13
+
+define void @_start() {
+entry:
doesn't *really* matter since you are creating a dylib, but `lld-macho` doesn't
actually treat `_start` as a special symbol (only `main`). maybe rename to
ellis updated this revision to Diff 526751.
ellis marked 3 inline comments as done.
ellis added a comment.
Add test to check that `PGOInstrumentationGen`(`Use`) are run
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151589/new/
MaskRay accepted this revision as: MaskRay.
MaskRay added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1356
+Arg *tools::getLastCSProfileGenerateArg(const ArgList ) {
+ auto *CSPGOGenerateArg =
ellis created this revision.
Herald added subscribers: wlei, ormris, wenlei, steven_wu, hiraditya.
Herald added projects: lld-macho, All.
Herald added a reviewer: lld-macho.
ellis added reviewers: int3, tejohnson, xur.
ellis updated this revision to Diff 526199.
ellis added a comment.
ellis edited
