steakhal requested changes to this revision.
steakhal added a comment.
This revision now requires changes to proceed.
I agree with @erichkeane.
However, I can also see that the code could be improved.
I don't understand why we have that variable hoisted from the guarded block in
the first
erichkeane added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:756
if (ReceiverType->isObjCIdType() || ReceiverType->isObjCClassType() ||
ASTCtxt.canAssignObjCInterfaces(ReceiverObjectPtrType, TrackedType)) {
const
erichkeane added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:756
if (ReceiverType->isObjCIdType() || ReceiverType->isObjCClassType() ||
ASTCtxt.canAssignObjCInterfaces(ReceiverObjectPtrType, TrackedType)) {
const
Manna added inline comments.
Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:756
if (ReceiverType->isObjCIdType() || ReceiverType->isObjCClassType() ||
ASTCtxt.canAssignObjCInterfaces(ReceiverObjectPtrType, TrackedType)) {
const
Manna created this revision.
Manna added a reviewer: erichkeane.
Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp,
donat.nagy, Szelethus, a.sidorin, baloghadamsoftware.
Herald added a reviewer: NoQ.
Herald added a project: All.
Manna requested review of this revision.
