MaggieYi added a comment.
Thanks Paul for your help.
Repository:
rL LLVM
http://reviews.llvm.org/D15222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
probinson added a comment.
In http://reviews.llvm.org/D15222#311896, @MaggieYi wrote:
> Could someone commit it for me please (as I do not have commit access)? Thanks
Done. Thanks Maggie!
Repository:
rL LLVM
http://reviews.llvm.org/D15222
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL255784: [PS4][Profile] add
"--dependent-lib=libclang_rt.profile-x86_64.a" to (authored by probinson).
Changed prior to commit:
http://reviews.llvm.org/D15222?vs=42874&id=43020#toc
Repository:
rL LLVM
MaggieYi added a comment.
Could someone commit it for me please (as I do not have commit access)? Thanks
http://reviews.llvm.org/D15222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
vsk accepted this revision.
vsk added a reviewer: vsk.
vsk added a comment.
This revision is now accepted and ready to land.
Lgtm
http://reviews.llvm.org/D15222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
MaggieYi updated this revision to Diff 42874.
MaggieYi added a comment.
Thanks, I have updated the test following your comments.
http://reviews.llvm.org/D15222
Files:
lib/Driver/Tools.cpp
test/Driver/ps4-runtime-flags.c
Index: test/Driver/ps4-runtime-flags.c
===
vsk added a comment.
Sure! Thanks.
http://reviews.llvm.org/D15222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaggieYi added a comment.
My patch changes 6 compiler flags, which are –coverage, -fprofile-arcs,
-fprofile-generate, -fprofile-generate=, -fprofile-instr-generate,
-fprofile-instr-generate=. I would like to keep line 7-10 in order to verify
the change to using “hasFlag” instead of “hasArg”. Fo
vsk added inline comments.
Comment at: lib/Driver/Tools.cpp:4067
@@ -4049,1 +4066,3 @@
+ // Add runtime flag for PS4 when PGO or Coverage are enabled.
+ if (getToolChain().getTriple().isPS4CPU())
Sorry, I don't know why I thought this was in ParsePIC. This see
MaggieYi updated this revision to Diff 42711.
MaggieYi added a comment.
Following Vedant's comments, two test issues have been fixed.
http://reviews.llvm.org/D15222
Files:
lib/Driver/Tools.cpp
test/Driver/ps4-runtime-flags.c
Index: test/Driver/ps4-runtime-flags.c
==
MaggieYi added a comment.
Thanks for reviewing the patch. I try to answer your questions, could you
please let me know if this makes sense to you?
Regards,
Comment at: lib/Driver/Tools.cpp:4064
@@ -4046,1 +4063,3 @@
+ // Add runtime flag for PS4 when PGO or Coverage are ena
vsk added a subscriber: vsk.
vsk added a comment.
Thanks, comments inline --
Comment at: lib/Driver/Tools.cpp:4064
@@ -4046,1 +4063,3 @@
+ // Add runtime flag for PS4 when PGO or Coverage are enabled.
+ if (getToolChain().getTriple().isPS4CPU())
Profiling in
MaggieYi added a comment.
Ping
http://reviews.llvm.org/D15222
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaggieYi created this revision.
MaggieYi added reviewers: filcab, probinson, jmagee, phillip.power.
MaggieYi added a subscriber: cfe-commits.
Dear All,
This patch adds “--dependent-lib= libclang_rt.profile-x86_64.a” to the compiler
command line when enabling code coverage on the PS4 target. A
14 matches
Mail list logo