[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

2023-06-07 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D152318#4402493 , @haowei wrote: > In D152318#4402234 , @mstorsjo > wrote: > >> FWIW, I'm curious about where you need `llvm-strings` in a MinGW setting. >> While it does match a

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

2023-06-07 Thread Haowei Wu via Phabricator via cfe-commits
haowei added a comment. In D152318#4402234 , @mstorsjo wrote: > FWIW, I'm curious about where you need `llvm-strings` in a MinGW setting. > While it does match a GNU binutils tool, I'm kinda curious where it is needed. llvm-strings exists in the

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

2023-06-07 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. FWIW, I'm curious about where you need `llvm-strings` in a MinGW setting. While it does match a GNU binutils tool, I'm kinda curious where it is needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152318/new/

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

2023-06-06 Thread Haowei Wu via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb398898dad9: [Fuchsia] Add llvm-strings to Fuchsia clang build. (authored by haowei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

2023-06-06 Thread Petr Hosek via Phabricator via cfe-commits
phosek accepted this revision. phosek added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152318/new/ https://reviews.llvm.org/D152318

[PATCH] D152318: [Fuchsia] Add llvm-strings to Fuchsia clang build

2023-06-06 Thread Haowei Wu via Phabricator via cfe-commits
haowei created this revision. haowei added reviewers: phosek, mcgrathr. Herald added subscribers: abrachet, mstorsjo. Herald added a project: All. haowei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds 'llvm-strings' to