[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f4d48d73d39: [clang] Replace use of Type::getPointerTo() (NFC) (authored by JOE1994, committed by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added a comment. In D152321#4428398 , @JOE1994 wrote: > With the updated revision, I don't see new test failures from `ninja > check-clang` & `ninja check-llvm` & `ninja check-clang-unit` & `ninja > check-llvm-unit` . Thank you, it was my

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added a comment. With the updated revision, I don't see new test failures from `ninja check-clang` & `ninja check-llvm` & `ninja check-clang-unit` & `ninja check-llvm-unit` . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2552-2554 auto AddrAS = addr ? addr->getType()->getPointerAddressSpace() : 0; - auto AddrInt8PtrTy = - AddrAS ? CGF.Int8Ty->getPointerTo(AddrAS) : CGF.Int8PtrTy; + auto AddrPtrTy = +

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 532164. JOE1994 added a comment. - Fix nullptr bug (fixes Clang regression test :` Clang :: CodeGen/constructor-attribute.c` ) - Following feedback from @barannikov88 - Rebase onto latest main : a76376cdb034d817803cbdb2f3f451487807124d

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2552-2554 auto AddrAS = addr ? addr->getType()->getPointerAddressSpace() : 0; - auto AddrInt8PtrTy = - AddrAS ? CGF.Int8Ty->getPointerTo(AddrAS) : CGF.Int8PtrTy; + auto AddrPtrTy = +

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 requested changes to this revision. barannikov88 added a comment. This revision now requires changes to proceed. @JOE1994 Please run the testsuite locally (`ninja check-clang`), there is at least one test that crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added a comment. I do not have commit access yet. Could one of the reviewers land this patch for me? Please use "Youngsuk Kim " to commit the change. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

nikic accepted this revision. nikic added a comment. LGTM -- do you have commit access, or should someone commit this for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/ https://reviews.llvm.org/D152321

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:2045 if (IsIndirect) -LLTy = LLTy->getPointerTo(0); +LLTy = llvm::PointerType::get(getVMContext(), 0); FrameFields.push_back(LLTy); nikic wrote: > getLLVMContext?

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 531889. JOE1994 added a comment. - Rebase onto latest llvm-project main : 2cd4dc59792578f833b838e3c9a376a4bcafc568 - Use `llvm::PointerType::getUnqual` whenever possible Repository:

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

nikic added a comment. Looks reasonable. Main note I have is that I think the use of getUnqual() over passing AddrSpace=0 would be preferred. Comment at: clang/lib/CodeGen/CGAtomic.cpp:91 auto Addr = CGF.Builder.CreatePointerBitCastOrAddrSpaceCast( -

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added a comment. I guess you need to rebase onto 066fb7a5 at least. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/ https://reviews.llvm.org/D152321

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. LGTM with CI fixed, thanks. I'd like @nikic to also take a look though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:170 Address CreateElementBitCast(Address Addr, llvm::Type *Ty, const llvm::Twine = "") { +return Address(Addr.getPointer(), Ty, barannikov88 wrote: >

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 531593. JOE1994 added a comment. - Apply suggestions from barannikov88 - Used `git clang-format` to tidy up code format Thank you for your feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added a comment. Please use clang-format on the modified lines. Comment at: clang/lib/CodeGen/CGBuilder.h:170 Address CreateElementBitCast(Address Addr, llvm::Type *Ty, const llvm::Twine = "") { +return

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:172 +auto *PtrTy = llvm::PointerType::get(Ty, Addr.getAddressSpace()); return Address(CreateBitCast(Addr.getPointer(), PtrTy, Name), Ty, Addr.getAlignment(),

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 529976. JOE1994 added a comment. - Update uses of `PointerType::get(Ty)` & `PointerType::getUnqual` to be in overloaded form of `PointerType::get` that takes LLVMContext& - Remove more unnecessary bitcasts which were previously overlooked. - Remove pointee

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

nikic added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:172 +auto *PtrTy = llvm::PointerType::get(Ty, Addr.getAddressSpace()); return Address(CreateBitCast(Addr.getPointer(), PtrTy, Name), Ty, Addr.getAlignment(),

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/CGBuilder.h:172 +auto *PtrTy = llvm::PointerType::get(Ty, Addr.getAddressSpace()); return Address(CreateBitCast(Addr.getPointer(), PtrTy, Name), Ty, Addr.getAlignment(),

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

nikic added a comment. In D152321#4403719 , @JOE1994 wrote: > Some tests that run with `-no-opaque-pointers` began failing after I updated > the revision to get rid of bitcasts. > The bitcasts are still needed if running Clang with

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added a comment. Some tests that run with `-no-opaque-pointers` began failing after I updated the revision to get rid of bitcasts. The bitcasts are still needed if running Clang with `-no-opaque-pointers`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 added inline comments. Comment at: clang/lib/CodeGen/Address.h:135 llvm::Constant *BitCast = llvm::ConstantExpr::getBitCast( -getPointer(), ElemTy->getPointerTo(getAddressSpace())); +getPointer(), llvm::PointerType::get(ElemTy, getAddressSpace()));

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 updated this revision to Diff 529317. JOE1994 added a comment. If `getPointerTo()` is used just to support an unnecessary bitcast, just get rid of the bitcast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

nikic added inline comments. Comment at: clang/lib/CodeGen/Address.h:135 llvm::Constant *BitCast = llvm::ConstantExpr::getBitCast( -getPointer(), ElemTy->getPointerTo(getAddressSpace())); +getPointer(), llvm::PointerType::get(ElemTy, getAddressSpace()));

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

JOE1994 created this revision. JOE1994 added a reviewer: nikic. Herald added a subscriber: StephenFan. Herald added a project: All. JOE1994 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Partial progress towards replacing in-tree uses of