[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

2023-06-15 Thread Timm Bäder via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb1aba4a10099: [clang][Diagnostics] Dont expand label fixit to the next line (authored by tbaeder). Changed prior to commit: https://reviews.llvm.org/D152525?vs=529922=531737#toc Repository: rG LLVM

[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

2023-06-13 Thread Christopher Di Bella via Phabricator via cfe-commits
cjdb accepted this revision. cjdb added a comment. Thanks for fixing this, it'll hopefully cause less frustration for devs :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152525/new/ https://reviews.llvm.org/D152525

[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

2023-06-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D152525#4408902 , @tbaeder wrote: > As far as the fixit goes, I guess the previous version was better, since it > didn't leave an

[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

2023-06-09 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder added a comment. As far as the fixit goes, I guess the previous version was better, since it didn't leave an empty line behind? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152525/new/ https://reviews.llvm.org/D152525

[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

2023-06-09 Thread Timm Bäder via Phabricator via cfe-commits
tbaeder created this revision. tbaeder added reviewers: aaron.ballman, cjdb. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Now that we print >1 line of code snippet, we printed another line of