dankm updated this revision to Diff 530070.
dankm added a comment.
Fix typo in release notes
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152570/new/
https://reviews.llvm.org/D152570
Files:
clang/docs/ReleaseNotes.rst
clang/lib/AST/Expr.cpp
dankm updated this revision to Diff 530069.
dankm added a comment.
Added unit test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152570/new/
https://reviews.llvm.org/D152570
Files:
clang/docs/ReleaseNotes.rst
clang/lib/AST/Expr.cpp
dankm added inline comments.
Comment at: clang/lib/AST/Expr.cpp:791
+public:
+ PrettyCallbacks(const LangOptions ) : LO(L) {}
+ std::string remapPath(StringRef Path) const override {
shafik wrote:
> This may not be a well known idiom but is widely
shafik added inline comments.
Comment at: clang/lib/AST/Expr.cpp:789
+class PrettyCallbacks final : public PrintingCallbacks {
+public:
This looks consistent with how other places that set `CallBacks` but I am not
familiar with this area.
dankm created this revision.
Herald added a project: All.
dankm added a comment.
dankm updated this revision to Diff 530046.
dankm published this revision for review.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
I still need to make a unit test for this. Should be
