[PATCH] D152632: [Clang] Add warnings for CWG2521

This revision was automatically updated to reflect the committed changes. Closed by commit rG5ce5e983f82c: [Clang] Add warnings for CWG2521 (authored by rZhBoYao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao added a comment. Hmm… I don’t see why check-format keeps failing. I `git clang-format` thrice before uploading. https://buildkite.com/llvm-project/premerge-checks/builds/164452 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/ https://reviews.llvm.org/D152632

[PATCH] D152632: [Clang] Add warnings for CWG2521

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM assuming precommit CI doesn't find any surprises. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/ https://reviews.llvm.org/D152632 ___ cfe-commits mailing

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao updated this revision to Diff 540072. rZhBoYao marked 6 inline comments as done. rZhBoYao edited the summary of this revision. rZhBoYao added a comment. -Wdeprecated-literal-operator will be on by default in https://reviews.llvm.org/D153156 CHANGES SINCE LAST ACTION

[PATCH] D152632: [Clang] Add warnings for CWG2521

aaron.ballman added a comment. Mostly just minor nits from me, otherwise this is looking close to good! If you're able to handle the libc++ failures as part of this patch as well, that'd be great (but isn't required for landing the changes). Comment at:

[PATCH] D152632: [Clang] Add warnings for CWG2521

ldionne added a comment. This breaks libc++: https://buildkite.com/llvm-project/clang-ci/builds/26#01894b7d-8d6f-4893-ab14-1147229390dc Doesn't mean don't land it, but please try to address the issues in this patch to keep everyone green. CHANGES SINCE LAST ACTION

[PATCH] D152632: [Clang] Add warnings for CWG2521

Endill accepted this revision as: Endill. Endill added a comment. DR testing side looks good, but you should wait for more approvals. Thank you for addressing all the issues there! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/ https://reviews.llvm.org/D152632

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao marked 6 inline comments as done. rZhBoYao added a comment. In D152632#4443284 , @shafik wrote: > I am wondering why we don't fold this into `-Wreserved-identifier` The "ud-suffix" of the user-defined-string-literal or the identifier in a

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao updated this revision to Diff 538678. rZhBoYao edited the summary of this revision. rZhBoYao added a comment. Defaults to on for C++23 only. Enable for all the language modes in another patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/

[PATCH] D152632: [Clang] Add warnings for CWG2521

shafik added inline comments. Comment at: clang/include/clang/Basic/IdentifierTable.h:56 + NotStartsWithUnderscore, + ContainsDoubleUnderscore, +}; I would think starting with a double underscore would also not be allowed, at least that is my reading.

[PATCH] D152632: [Clang] Add warnings for CWG2521

shafik added a comment. I am wondering why we don't fold this into `-Wreserved-identifier` CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/ https://reviews.llvm.org/D152632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao updated this revision to Diff 532223. rZhBoYao edited the summary of this revision. rZhBoYao added a comment. Depends on D153156 PS: I'm going on a vacation for 2 weeks. See you guys in July :) CHANGES SINCE LAST ACTION

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:411 + "identifier '%0' preceded by space(s) in the literal operator declaration " + "is deprecated">, InGroup, DefaultIgnore; def warn_reserved_module_name : Warning<

[PATCH] D152632: [Clang] Add warnings for CWG2521

Endill added a comment. Thank you for taking care of other tests under `dr25xx.cpp`! In D152632#4412075 , @rZhBoYao wrote: > Overhaul for `dr25xx.cpp`. > > For each test case, tried to support as many language modes as possible. > Not sure what those

[PATCH] D152632: [Clang] Add warnings for CWG2521

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:411 + "identifier '%0' preceded by space(s) in the literal operator declaration " + "is deprecated">, InGroup, DefaultIgnore; def warn_reserved_module_name : Warning<

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao updated this revision to Diff 530304. rZhBoYao added a comment. Overhaul for `dr25xx.cpp`. For each test case, tried to support as many language modes as possible. Not sure what those `-triple x86_64-unknown-unknown` are for? I leave them there nonetheless.

[PATCH] D152632: [Clang] Add warnings for CWG2521

Endill added inline comments. Comment at: clang/test/CXX/drs/dr25xx.cpp:2 +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown %s -verify -Wdeprecated-literal-operator +// RUN: %clang_cc1 -std=c++20 -triple x86_64-unknown-unknown %s -verify -Wdeprecated

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao updated this revision to Diff 530292. rZhBoYao added a comment. Addressed comments. Thanks for letting me know how to structure tests for DRs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152632/new/ https://reviews.llvm.org/D152632 Files: clang/docs/ReleaseNotes.rst

[PATCH] D152632: [Clang] Add warnings for CWG2521

Endill requested changes to this revision. Endill added a comment. This revision now requires changes to proceed. Thank you for working on this! In D152632#4411587 , @rZhBoYao wrote: > Few questions: > I think this applies to all the language modes?

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao added a reviewer: clang-language-wg. rZhBoYao added a comment. Few questions: I think this applies to all the language modes? Somehow, https://wg21.link/CWG2521 is not redirecting to https://cplusplus.github.io/CWG/issues/2521.html. Is this normal? Repository: rG LLVM Github

[PATCH] D152632: [Clang] Add warnings for CWG2521

rZhBoYao created this revision. rZhBoYao added a reviewer: serge-sans-paille. Herald added a project: All. rZhBoYao requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. 1. Teach -Wuser-defined-literals to warn on using double underscores in