[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

This revision was automatically updated to reflect the committed changes. Closed by commit rG184931853924: [clang][ExtractAPI] Add support for Objective-C categories (authored by Ruturaj4). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152770/new/ h

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

dang accepted this revision. dang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152770/new/ https://reviews.llvm.org/D152770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 updated this revision to Diff 550303. Ruturaj4 marked an inline comment as done. Ruturaj4 added a comment. - [clang][ExtractAPI] Add support for Objective-C categories 1. Updating D152770 : [clang][ExtractAPI] Add support for Objective-C categories # 2.

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

dang added inline comments. Comment at: clang/test/ExtractAPI/objc_various_categories.m:8 +// RUN: %t/myclass_1.h \ +// RUN: %t/input.h -o %t/output.json | FileCheck -allow-empty %s + I don't think you need to have MyClass2 and the associated myclass2.h. It's fi

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 updated this revision to Diff 548825. Ruturaj4 added a comment. - [clang][ExtractAPI] Add support for Objective-C categories - [clang][ExtractAPI] Add support for Objective-C categories - [clang][ExtractAPI] Add support for Objective-C categories - [clang][ExtractAPI] Add support for Obje

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152770/new/ https://reviews.llvm.org/D152770 ___ cfe

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 updated this revision to Diff 546683. Ruturaj4 added a comment. 1. Updating D152770 : [clang][ExtractAPI] Add support for Objective-C categories # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:488 + bool IsFromExternalModule = true; + for (const auto &Interface : API.getObjCInterfaces()) { +if (InterfaceDecl->getName() == Interface.second.get()->Name) {

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 updated this revision to Diff 546682. Ruturaj4 marked 4 inline comments as done. Ruturaj4 added a comment. 1. Updating D152770 : [clang][ExtractAPI] Add support for Objective-C categories # 2. Enter a brief description of the changes included in this u

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:488 + bool IsFromExternalModule = true; + for (const auto &Interface : API.getObjCInterfaces()) { +if (InterfaceDecl->getName() == Interface.second.get()->Name) { I t

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 updated this revision to Diff 546074. Ruturaj4 added a comment. - [clang][ExtractAPI] Add support for Objective-C categories - [clang][ExtractAPI] Add support for Objective-C categories 1. Updating D152770 : [clang][ExtractAPI] Add support for Objective

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 updated this revision to Diff 543982. Ruturaj4 added a comment. 1. Updating D152770 : [clang][ExtractAPI] Add support for Objective-C categories # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

zixuw added a comment. Thanks for the patch! Like I mentioned in the inline comments, I'm not sure I understand the need of the "abstract" (in the sense that it's not really a concrete API) subtype of `APIRecord`. The design doesn't feel right within the existing structure. If I recall the orig

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 created this revision. Herald added a reviewer: ributzka. Herald added a project: All. Ruturaj4 added a reviewer: dang. Ruturaj4 edited the summary of this revision. Ruturaj4 edited the summary of this revision. Ruturaj4 updated this revision to Diff 537064. Ruturaj4 added a comment. Rutur