[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

zahiraam added a comment. In D152818#4421064 , @nicolerabjohn wrote: > I've opened an issue (https://github.com/llvm/llvm-project/issues/63063) > where we hit the same assertion. There's a smaller test case, and we've done > enough investigation that

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

nicolerabjohn added a comment. I've opened an issue (https://github.com/llvm/llvm-project/issues/63063) where we hit the same assertion. There's a smaller test case, and we've done enough investigation that we understand the problem. I'd be happy to discuss over on the issue as well.

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

rjmccall added a comment. I'd guess we're not resetting the pragma state appropriately when instantiating templates. Expressions should be governed by the pragmas in scope at the point of definition, not at the point of instantiation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. In D152818#4417704 , @zahiraam wrote: > In D152818#4417683 , @tbaeder wrote: > >> In D152818#4417649

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

zahiraam added a comment. In D152818#4417683 , @tbaeder wrote: > In D152818#4417649 , @zahiraam > wrote: > >> In D152818#4417644 , @tbaeder >> wrote: >> >>> Has the

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

tbaeder added a comment. In D152818#4417649 , @zahiraam wrote: > In D152818#4417644 , @tbaeder wrote: > >> Has the test case been obfuscated on purpose? > > This is a smaller reproducible from creduce. Didn't

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

zahiraam added a comment. In D152818#4417644 , @tbaeder wrote: > Has the test case been obfuscated on purpose? This is a smaller reproducible from creduce. Didn't know if it would be OK to have an include in a LIT test? Repository: rG LLVM Github

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

tbaeder added a comment. Has the test case been obfuscated on purpose? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152818/new/ https://reviews.llvm.org/D152818 ___ cfe-commits mailing list

[PATCH] D152818: [Clang] Fix assertion when pragma FENV_ACCESS is used with a throw function.

zahiraam created this revision. zahiraam added a reviewer: aaron.ballman. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. See issue here: https://godbolt.org/z/aYME8KTdn Repository: rG LLVM Github Monorepo