[PATCH] D152829: clang: Add start of header test for __clang_hip_libdevice_declares

2023-06-30 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm closed this revision. arsenm added a comment. 40bb302c451ec1a8f6a2b8238e0a56448b8e1a12 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152829/new/ https://reviews.llvm.org/D152829 __

[PATCH] D152829: clang: Add start of header test for __clang_hip_libdevice_declares

2023-06-26 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152829/new/ https://reviews.llvm.org/D152829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D152829: clang: Add start of header test for __clang_hip_libdevice_declares

2023-06-13 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm added a comment. In D152829#4419016 , @JonChesterfield wrote: > That seems like something we should fix. Visibility/dso really should be the > same default. I don't know what that fp thing is Whether you're allowed to turn x * y + z into an fma

[PATCH] D152829: clang: Add start of header test for __clang_hip_libdevice_declares

2023-06-13 Thread Jon Chesterfield via Phabricator via cfe-commits
JonChesterfield added a comment. That seems like something we should fix. Visibility/dso really should be the same default. I don't know what that fp thing is CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152829/new/ https://reviews.llvm.org/D152829 ___

[PATCH] D152829: clang: Add start of header test for __clang_hip_libdevice_declares

2023-06-13 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm updated this revision to Diff 531048. arsenm added a comment. Use -verify CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152829/new/ https://reviews.llvm.org/D152829 Files: clang/test/Headers/__clang_hip_libdevice_declares.cpp Index: clang/test/Headers/__clang_hip_libdevice_de

[PATCH] D152829: clang: Add start of header test for __clang_hip_libdevice_declares

2023-06-13 Thread Matt Arsenault via Phabricator via cfe-commits
arsenm created this revision. arsenm added reviewers: ronlieb, jdoerfert, JonChesterfield, tra, ddpagan, doru1004. Herald added a subscriber: yaxunl. Herald added a project: All. arsenm requested review of this revision. Herald added subscribers: jplehr, sstefan1, wdng. It was shockingly difficul