[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76482078cdd2: [RISCV][POC] Model frm control for vfadd (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4816 + case RISCVVector::BI__builtin_rvv_vfadd_vf_rm_tu: + case RISCVVector::BI__builtin_rvv_vfadd_vv_rm_tama: + case RISCVVector::BI__builtin_rvv_vfadd_vf_rm_tama: craig.topper wrote: >

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4816 + case RISCVVector::BI__builtin_rvv_vfadd_vf_rm_tu: + case RISCVVector::BI__builtin_rvv_vfadd_vv_rm_tama: + case RISCVVector::BI__builtin_rvv_vfadd_vf_rm_tama: not related to

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 539413. eopXD added a comment. Change: - Rebase to latest main - let `hasPostISelHook = 1` for PseudoVFADD to trigger code under `AdjustInstrPostInstrSelection`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 539222. eopXD added a comment. Under RISCVInsertReadWriteCSR, add implicit depdendency to MI if rounding mode is FRM_DYN. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper added a comment. I think this conflicts with https://reviews.llvm.org/D154245 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 ___ cfe-commits

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 538748. eopXD added a comment. Fix bug, should be checking MI.readsRegister(RISCV::FRM) under AdjustInstrPostInstrSelection. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 536964. eopXD added a comment. Resolve test case failure in llvm/test/CodeGen/RISCV/rvv/combine-vmv.ll Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files:

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 536700. eopXD added a comment. Undo the previous diff. There was no bug in the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files:

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 536699. eopXD added a comment. Fix bug in ManualCodeGen of vfadd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 536688. eopXD added a comment. Update suffix from `vfadd_vv_i32m1_{policy_suffix, if any}_rm` to `vfadd_vv_i32m1_rm_{policy_suffix, if any}` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

kito-cheng accepted this revision. kito-cheng added a comment. LGTM, Give my blessing, thanks for moving this forward :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 535446. eopXD marked 2 inline comments as done. eopXD added a comment. Address more comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files:

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInsertReadWriteCSR.cpp:78 + +// The value '7' is a hint to this pass to not alter the frm value. +if (FRMImm == RISCVFPRndMode::DYN) Don't write 7 here Repository: rG

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h:21 #include "llvm/ADT/StringSwitch.h" +#include "llvm/CodeGen/MachineInstr.h" #include "llvm/MC/MCInstrDesc.h" We can't include a CodeGen header in MCTargetDesc

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 535438. eopXD marked 6 inline comments as done. eopXD added a comment. Address more comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files:

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInsertReadWriteCSR.cpp:78 +// The value '7' is a hint to this pass to not alter the frm value. +if (FRMImm == 7) + continue; Use `RISCVFPRndMode::DYN`?

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 535425. eopXD marked 2 inline comments as done. eopXD added a comment. Address comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files:

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInsertReadWriteCSR.cpp:105 +.addImm(FRMImm); +MI.addOperand(MachineOperand::CreateReg(RISCV::FRM, /*IsDef*/ false, +/*IsImp*/ true));

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532996. eopXD added a comment. Rebase to latest main. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532839. eopXD added a comment. Add SemaChecking and corresponding test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files:

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532836. eopXD added a comment. Rebase: Add `sew` parameter that other templates have added too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files:

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532800. eopXD added a comment. Fix ManualCodegen for vfadd. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532797. eopXD added a comment. Remove unnecessary include-s. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files: clang/include/clang/Basic/riscv_vector.td

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532796. eopXD marked an inline comment as done. eopXD added a comment. Save and restore FRM in RISCVInsertReadWriteCSR. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 532536. eopXD added a comment. Herald added a subscriber: qcolombet. Update code: - Change value to indicate no rounding mode change from `99` to `7`. - Add code under `RISCVDAGToDAGISel::performCombineVMergeAndVOps` to deal with the extra rounding mode

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInsertReadWriteCSR.cpp:105 + +BuildMI(MBB, MI, MI.getDebugLoc(), TII->get(RISCV::WriteFRMImm)) +.addImm(FRMImm); craig.topper wrote: > Don't we need to restore the original

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInsertReadWriteCSR.cpp:105 + +BuildMI(MBB, MI, MI.getDebugLoc(), TII->get(RISCV::WriteFRMImm)) +.addImm(FRMImm); Don't we need to restore the original FRM value after

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 531722. eopXD added a comment. Update code based on edit of parent revision. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files:

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD updated this revision to Diff 531701. eopXD edited the summary of this revision. eopXD added a comment. Resolve test case failures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 Files:

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD,