This revision was automatically updated to reflect the committed changes.
Closed by commit rG982a87ab74d8: [CLANG] Fix potential null pointer dereference
bugs (authored by Manna).
Changed prior to commit:
https://reviews.llvm.org/D153033?vs=532138=533742#toc
Repository:
rG LLVM Github
Manna added a comment.
Thank you for reviews @aaron.ballman!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153033/new/
https://reviews.llvm.org/D153033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153033/new/
https://reviews.llvm.org/D153033
___
cfe-commits mailing
Manna marked an inline comment as done.
Manna added a comment.
ping @aaron.ballman
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153033/new/
https://reviews.llvm.org/D153033
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Manna marked an inline comment as done.
Manna added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:3368
- VD = VD->getCanonicalDecl();
+ VD = cast(VD->getCanonicalDecl());
auto I = FunctionGlobalizedDecls.find(CGF.CurFn);
Manna updated this revision to Diff 532138.
Manna added a comment.
Address review comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D153033/new/
https://reviews.llvm.org/D153033
Files:
clang/lib/AST/ASTContext.cpp
clang/lib/AST/MicrosoftMangle.cpp
aaron.ballman added inline comments.
Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:3368
- VD = VD->getCanonicalDecl();
+ VD = cast(VD->getCanonicalDecl());
auto I = FunctionGlobalizedDecls.find(CGF.CurFn);
This is unnecessary, `getCanonicalDecl()`
Manna added inline comments.
Comment at: clang/lib/Analysis/ThreadSafety.cpp:505-511
const unsigned *i = C.lookup(D);
llvm::errs() << " -> ";
+ if (!i) {
+llvm::errs() << "<>";
+return;
+ }
dumpVarDefinitionName(*i);
Manna updated this revision to Diff 531976.
Manna retitled this revision from "[NFC][CLANG] Fix potential null pointer
dereference bugs" to "[CLANG]Fix potential null pointer dereference bugs".
Manna added a comment.
Herald added subscribers: steakhal, martong.
Address review comment and update
