[PATCH] D153205: [clang-format] Add new block type ListInit

gedare updated this revision to Diff 537399. gedare added a comment. Address comments from owenpan. Do not add the new block type, and instead check explicitly for the equal sign before an opening right brace. Herald added a comment. NOTE: Clang-Format Team Automated Review Comment Your

[PATCH] D153205: [clang-format] Add new block type ListInit

owenpan added a comment. In D153205#4438782 , @HazardyKnusperkeks wrote: > In D153205#4437966 , > @MyDeveloperDay wrote: > >> My only concern is that this changes behaviour without someone making the >>

[PATCH] D153205: [clang-format] Add new block type ListInit

gedare added a comment. Can someone land for me? thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153205/new/ https://reviews.llvm.org/D153205 ___ cfe-commits mailing list

[PATCH] D153205: [clang-format] Add new block type ListInit

HazardyKnusperkeks added a comment. In D153205#4437966 , @MyDeveloperDay wrote: > My only concern is that this changes behaviour without someone making the > conscious decision to make that change, now as much as I can't understand why > someone would

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added a comment. My only concern is that this changes behaviour without someone making the conscious decision to make that change, now as much as I can't understand why someone would want to put the `}` onto the same line, it will only take on person to say "hey I liked it like

[PATCH] D153205: [clang-format] Add new block type ListInit

gedare updated this revision to Diff 532967. gedare added a comment. Do not use temporary variable for getBlockKind(). Fix test case syntax errors. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153205/new/

[PATCH] D153205: [clang-format] Add new block type ListInit

gedare added a comment. In D153205#4431235 , @HazardyKnusperkeks wrote: > You add a lot of checks and I honestly can't say if it does not affect other > code that is not covered by the tests. Not much I can do about that. I guess it is worth noting

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added a comment. In principle I like this as its annoyed me for years Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153205/new/ https://reviews.llvm.org/D153205 ___ cfe-commits mailing

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:25511 + // Designated initializers. + verifyFormat("int LongVariable[1] = {\n" + "[0] = 1000, [1] = 2000\n" nit [2]

[PATCH] D153205: [clang-format] Add new block type ListInit

MyDeveloperDay added inline comments. Comment at: clang/lib/Format/FormatToken.cpp:79 bool FormatToken::opensBlockOrBlockTypeList(const FormatStyle ) const { + auto bk = getBlockKind(); // C# Does not indent object initialisers as continuations.

[PATCH] D153205: [clang-format] Add new block type ListInit

HazardyKnusperkeks added a comment. In D153205#4430528 , @owenpan wrote: > It seems to me that there has been a proliferation of new options being > proposed and/or accepted recently. I'd like to remind everyone of the > long-standing policy >

[PATCH] D153205: [clang-format] Add new block type ListInit

gedare added a comment. In D153205#4430528 , @owenpan wrote: > It seems to me that there has been a proliferation of new options being > proposed and/or accepted recently. I'd like to remind everyone of the > long-standing policy >

[PATCH] D153205: [clang-format] Add new block type ListInit

owenpan added a comment. It seems to me that there has been a proliferation of new options being proposed and/or accepted recently. I'd like to remind everyone of the long-standing policy of adding new

[PATCH] D153205: [clang-format] Add new block type ListInit

gedare created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperDay. gedare requested review of this revision. C89 and C90 list initializers are treated differently than