[PATCH] D153205: [clang-format] Support block indenting array/struct list initializers

2023-07-06 Thread Owen Pan via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG413a7cb6e0db: [clang-format] Support block indenting array/struct list initializers (authored by gedare, committed by owenpan). Repository: rG

[PATCH] D153205: [clang-format] Support block indenting array/struct list initializers

2023-07-06 Thread Gedare Bloom via Phabricator via cfe-commits
gedare marked an inline comment as done. gedare added a comment. In D153205#4475836 , @owenpan wrote: > Do you need to update the current diff to show the net change? For example, > the unit tests you added don't show up as a diff right now. Done. Not

[PATCH] D153205: [clang-format] Support block indenting array/struct list initializers

2023-07-06 Thread Gedare Bloom via Phabricator via cfe-commits
gedare updated this revision to Diff 537761. gedare added a comment. Update and refresh diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153205/new/ https://reviews.llvm.org/D153205 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D153205: [clang-format] Support block indenting array/struct list initializers

2023-07-05 Thread Owen Pan via Phabricator via cfe-commits
owenpan added a comment. Do you need to update the current diff to show the net change? For example, the unit tests you added don't show up as a diff right now. Comment at: clang/include/clang/Format/Format.h:95-98 /// \warning -/// Note: This currently only applies

[PATCH] D153205: [clang-format] Support block indenting array/struct list initializers

2023-07-05 Thread Gedare Bloom via Phabricator via cfe-commits
gedare updated this revision to Diff 537531. gedare added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153205/new/ https://reviews.llvm.org/D153205 Files: clang/docs/ClangFormatStyleOptions.rst

[PATCH] D153205: [clang-format] Support block indenting array/struct list initializers

2023-07-05 Thread Gedare Bloom via Phabricator via cfe-commits
gedare added inline comments. Comment at: clang/include/clang/Format/Format.h:95-98 /// \warning -/// Note: This currently only applies to parentheses. +/// Note: This currently only applies to parentheses and braced list +/// initializers when

[PATCH] D153205: [clang-format] Support block indenting array/struct list initializers

2023-07-05 Thread Owen Pan via Phabricator via cfe-commits
owenpan added inline comments. Comment at: clang/include/clang/Format/Format.h:95-98 /// \warning -/// Note: This currently only applies to parentheses. +/// Note: This currently only applies to parentheses and braced list +/// initializers when

[PATCH] D153205: [clang-format] Support block indenting array/struct list initializers

2023-07-05 Thread Gedare Bloom via Phabricator via cfe-commits
gedare requested review of this revision. gedare marked 8 inline comments as done. gedare added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:365-367 + (Current.is(tok::r_brace) && Style.Cpp11BracedListStyle && +

[PATCH] D153205: [clang-format] Support block indenting array/struct list initializers

2023-07-05 Thread Gedare Bloom via Phabricator via cfe-commits
gedare updated this revision to Diff 537402. gedare added a comment. Regenerate docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153205/new/ https://reviews.llvm.org/D153205 Files: clang/docs/ClangFormatStyleOptions.rst