ABataev abandoned this revision.
ABataev added a comment.
Revision is abandoned as the construct is supported already.
http://reviews.llvm.org/D15321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
fraggamuffin marked 15 inline comments as done.
fraggamuffin added a comment.
Thanks for the pre-xmas review.
Comment at: include/clang/AST/DeclOpenMP.h:98
@@ +97,3 @@
+///
+class OMPDeclareTargetDecl : public Decl, public DeclContext {
+ friend class ASTDeclReader;
ABataev added a comment.
Hello Michael,
Thanks for working on this. I still think we don't need OMPDeclareTargetDecl
here and we can handle everything with an attribute. Try to implement
everything just with an attribute and without OMPDeclareTargetDecl.
http://reviews.llvm.org/D15321
ABataev added inline comments.
Comment at: lib/Parse/ParseOpenMP.cpp:209
@@ -142,2 +208,3 @@
case OMPD_taskloop_simd:
+ default:
Diag(Tok, diag::err_omp_unexpected_directive)
fraggamuffin wrote:
> ABataev wrote:
> > Do not add default:, coding standard
fraggamuffin removed rL LLVM as the repository for this revision.
fraggamuffin updated this revision to Diff 42307.
fraggamuffin marked an inline comment as done.
fraggamuffin added a comment.
This is just an interim full diff file of changes accepted so far. I still need
to address the
ABataev added a comment.
I think we'd better to try to use attributes for declare target. I think it
will be much easier and correct solution rather than adding a new declaration
Comment at: include/clang/AST/DeclBase.h:164
@@ -163,3 +163,3 @@
/// has been declared
ABataev added a comment.
Michael, please provide full diff log, as described in
http://llvm.org/docs/Phabricator.html (with full context)
Repository:
rL LLVM
http://reviews.llvm.org/D15321
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
fraggamuffin created this revision.
fraggamuffin added a reviewer: cfe-commits.
fraggamuffin set the repository for this revision to rL LLVM.
Add parsing, sema analysis for 'declare target' construct for OpenMP 4.0.
Summary
The declare target directive specifies that variables, functions (C, C++
